Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-23 10:15:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1595901 - Add spoc privacy modal fix, bug fixes, and personalization switch to New Tab Page r=Mardak

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D52769

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Scott 2019-11-12 23:28:32 +00:00
parent a055b60f76
commit aef62fb9fe
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
browser/components/newtab/content-src/components/TopSites/TopSitesConstants.js
View File

@ -20,6 +20,7 @@ export const TOP_SITES_SPOC_CONTEXT_MENU_OPTIONS = [
"OpenInPrivateWindow",
"Separator",
"BlockUrl",
"ShowPrivacyInfo",
];
// the special top site for search shortcut experiment can only have the option to unpin (which removes) the topsite
export const TOP_SITES_SEARCH_SHORTCUTS_CONTEXT_MENU_OPTIONS = [

5
browser/components/newtab/data/content/activity-stream.bundle.js
View File

@ -6894,7 +6894,7 @@ __webpack_require__.r(__webpack_exports__);
* You can obtain one at http://mozilla.org/MPL/2.0/. */
const TOP_SITES_SOURCE = "TOP_SITES";
const TOP_SITES_CONTEXT_MENU_OPTIONS = ["CheckPinTopSite", "EditTopSite", "Separator", "OpenInNewWindow", "OpenInPrivateWindow", "Separator", "BlockUrl", "DeleteUrl"];
const TOP_SITES_SPOC_CONTEXT_MENU_OPTIONS = ["PinSpocTopSite", "Separator", "OpenInNewWindow", "OpenInPrivateWindow", "Separator", "BlockUrl"]; // the special top site for search shortcut experiment can only have the option to unpin (which removes) the topsite
const TOP_SITES_SPOC_CONTEXT_MENU_OPTIONS = ["PinSpocTopSite", "Separator", "OpenInNewWindow", "OpenInPrivateWindow", "Separator", "BlockUrl", "ShowPrivacyInfo"]; // the special top site for search shortcut experiment can only have the option to unpin (which removes) the topsite
const TOP_SITES_SEARCH_SHORTCUTS_CONTEXT_MENU_OPTIONS = ["CheckPinTopSite", "Separator", "BlockUrl"]; // minimum size necessary to show a rich icon instead of a screenshot
@ -14695,7 +14695,8 @@ const FLUENT_FILES = ["branding/brand.ftl", "browser/branding/brandings.ftl", "b
const helpers = {
selectInterruptAndTriplets(message = {}, interruptCleared) {
const hasInterrupt = interruptCleared === true ? false : Boolean(message.content);
const hasTriplets = Boolean(message.bundle && message.bundle.length);
const hasTriplets = Boolean(message.bundle && message.bundle.length); // Allow 1) falsy to not render a header 2) default welcome 3) custom header
const tripletsHeaderId = message.tripletsHeaderId === undefined ? "onboarding-welcome-header" : message.tripletsHeaderId;
const UTMTerm = message.utm_term || "";
return {

2
browser/components/newtab/lib/ActivityStream.jsm
View File

@ -492,7 +492,7 @@ const PREFS_CONFIG = new Map([
enabled: isEnabled,
show_spocs: showSpocs({ geo }),
hardcoded_layout: true,
personalized: false,
personalized: true,
// This is currently an exmple layout used for dev purposes.
layout_endpoint:
"https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=basic",