diff --git a/.flake8 b/.flake8 index 48d7a27eada5..89abb047d56c 100644 --- a/.flake8 +++ b/.flake8 @@ -74,9 +74,6 @@ exclude = tools/crashreporter/*.configure, .ycm_extra_conf.py, - # This file uses py3.7 only syntax, so can't currently be checked by flake8 in-tree - tools/crashreporter/system-symbols/win/symsrv-fetch.py - # See: # - http://flake8.pycqa.org/en/latest/user/error-codes.html # - http://pep8.readthedocs.io/en/latest/intro.html#configuration diff --git a/tools/crashreporter/system-symbols/win/symsrv-fetch.py b/tools/crashreporter/system-symbols/win/symsrv-fetch.py index 6062d0e5a68c..b188aba6aaff 100644 --- a/tools/crashreporter/system-symbols/win/symsrv-fetch.py +++ b/tools/crashreporter/system-symbols/win/symsrv-fetch.py @@ -24,20 +24,19 @@ # The script also depends on having write access to the directory it is # installed in, to write the skiplist text file. +import argparse +import asyncio +import logging +import os +import shutil +import zipfile +from collections import defaultdict +from tempfile import mkdtemp +from urllib.parse import quote, urljoin + from aiofile import AIOFile, LineReader from aiohttp import ClientSession, ClientTimeout from aiohttp.connector import TCPConnector -import argparse -import asyncio -import os -import shutil -import logging -from collections import defaultdict -from tempfile import mkdtemp -from urllib.parse import urljoin -from urllib.parse import quote -import zipfile - # Just hardcoded here MICROSOFT_SYMBOL_SERVER = "https://msdl.microsoft.com/download/symbols/" @@ -47,7 +46,7 @@ MOZILLA_SYMBOL_SERVER = ( ) MISSING_SYMBOLS_URL = "https://symbols.mozilla.org/missingsymbols.csv?microsoft=only" HEADERS = {"User-Agent": USER_AGENT} -SYM_SRV = "SRV*{0}*https://msdl.microsoft.com/download/symbols;SRV*{0}*https://software.intel.com/sites/downloads/symbols;SRV*{0}*https://download.amd.com/dir/bin;SRV*{0}*https://driver-symbols.nvidia.com" +SYM_SRV = "SRV*{0}*https://msdl.microsoft.com/download/symbols;SRV*{0}*https://software.intel.com/sites/downloads/symbols;SRV*{0}*https://download.amd.com/dir/bin;SRV*{0}*https://driver-symbols.nvidia.com" # noqa TIMEOUT = 7200 RETRIES = 5 @@ -517,7 +516,7 @@ def main(): ) log.info( - f"{stats_collect['is_there']} already present, {stats_skipped['ignorelist']} in ignored list, " + f"{stats_collect['is_there']} already present, {stats_skipped['ignorelist']} in ignored list, " # noqa f"{stats_skipped['skiplist']} skipped, {stats_collect['no_pdb']} not found, " f"{stats_dump['dump_error']} processed with errors, " f"{stats_dump['no_bin']} processed but with no binaries (x86_64)"