Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 00:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[not part of build] slight optimization, check for cache file existence before creating an entry and attempting to open a transport for it.

Browse Source
This commit is contained in:
beard%netscape.com 2001-03-02 20:14:41 +00:00
parent 88c1e43a65
commit af49e27bcf
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
netwerk/cache/src/nsDiskCacheDevice.cpp vendored
View File

@ -590,27 +590,26 @@ nsresult nsDiskCacheDevice::updateDiskCacheEntry(nsCacheEntry* entry)
nsresult nsDiskCacheDevice::readDiskCacheEntry(nsCString* key, nsCacheEntry ** result)
{
nsresult rv = NS_ERROR_OUT_OF_MEMORY;
nsCacheEntry* entry = nsnull;
// up front, check to see if the file we are looking for exists.
nsCOMPtr<nsIFile> file;
nsresult rv = getFileForKey(key->get(), PR_TRUE, getter_AddRefs(file));
if (NS_FAILED(rv)) return rv;
PRBool exists;
rv = file->Exists(&exists);
if (NS_FAILED(rv) || !exists) return NS_ERROR_NOT_AVAILABLE;
nsCString* newKey = new nsCString(key->get());
if (!newKey) return NS_ERROR_OUT_OF_MEMORY;
nsCacheEntry* entry = new nsCacheEntry(newKey, PR_TRUE, nsICache::STORE_ON_DISK);
if (!entry) { delete newKey; return NS_ERROR_OUT_OF_MEMORY; }
do {
nsCString* newKey = new nsCString(key->get());
if (!newKey) return NS_ERROR_OUT_OF_MEMORY;
entry = new nsCacheEntry(newKey, PR_TRUE, nsICache::STORE_ON_DISK);
if (!entry) {
delete newKey;
return NS_ERROR_OUT_OF_MEMORY;
}
DiskCacheEntry* diskEntry = ensureDiskCacheEntry(entry);
if (!diskEntry) break;
nsCOMPtr<nsITransport>& transport = diskEntry->getMetaTransport(nsICache::ACCESS_READ);
if (!transport) {
nsCOMPtr<nsIFile> file;
nsresult rv = getFileForKey(key->get(), PR_TRUE, getter_AddRefs(file));
if (NS_FAILED(rv)) break;
rv = getTransportForFile(file, nsICache::ACCESS_READ, getter_AddRefs(transport));
if (NS_FAILED(rv)) break;
}