Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 22:05:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 665780 - "Racy code in background_update of test_blocklistchange.js". r=rs

Browse Source 
--HG--
extra : rebase_source : f2062288a65527eb0605f94f38e731306b807f53
This commit is contained in:
Dave Townsend 2011-06-22 16:49:18 -07:00
parent bf73757e39
commit aff5447fec
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
toolkit/mozapps/extensions/test/xpcshell/test_blocklistchange.js
View File

@ -363,6 +363,7 @@ function load_blocklist(aFile, aCallback) {
// to complete
function background_update(aCallback) {
var installCount = 0;
var backgroundCheckCompleted = false;
AddonManager.addInstallListener({
onNewInstall: function(aInstall) {
@ -371,20 +372,31 @@ function background_update(aCallback) {
onInstallEnded: function(aInstall) {
installCount--;
// Wait until all started installs have completed
if (installCount)
return;
AddonManager.removeInstallListener(this);
// If the background check hasn't yet completed then let that call the
// callback when it is done
if (!backgroundCheckCompleted)
return;
do_execute_soon(aCallback);
}
});
Services.obs.addObserver(function() {
Services.obs.removeObserver(arguments.callee, "addons-background-update-complete");
backgroundCheckCompleted = true;
if (!installCount)
do_execute_soon(aCallback);
// If any new installs have started then we'll call the callback once they
// are completed
if (installCount)
return;
do_execute_soon(aCallback);
}, "addons-background-update-complete", false);
AddonManagerPrivate.backgroundUpdateCheck();