Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-24 11:27:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Backed out changeset 397ad8a55255 (bug 1645046) for causing multiple wpt failures CLOSED TREE

Browse Source
This commit is contained in:
Noemi Erli 2020-06-30 00:19:28 +03:00
parent 68e6f06c65
commit b04c81aab3
5 changed files with 62 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
dom/html/test/forms/test_button_attributes_reflection.html
View File

@ -50,19 +50,16 @@ reflectLimitedEnumerated({
});
// .formMethod
add_task(async function() {
await SpecialPowers.pushPrefEnv({ set: [["dom.dialog_element.enabled", false]] })
reflectLimitedEnumerated({
element: document.createElement("button"),
attribute: "formMethod",
validValues: [ "get", "post" ],
invalidValues: [ "put", "", "tulip" ],
unsupportedValues: [ "dialog" ],
defaultValue: {
invalid: "get",
missing: "",
}
});
reflectLimitedEnumerated({
element: document.createElement("button"),
attribute: "formMethod",
validValues: [ "get", "post" ],
invalidValues: [ "put", "", "tulip" ],
unsupportedValues: [ "dialog" ],
defaultValue: {
invalid: "get",
missing: "",
}
});
// .formMethod when dialog is enabled

1
dom/html/test/mochitest.ini
View File

@ -429,6 +429,7 @@ skip-if = toolkit == 'android' && !is_fennec # Bug 1525959
[test_bug1323815.html]
[test_change_crossorigin.html]
[test_checked.html]
[test_dialog_pref.html]
[test_dir_attributes_reflection.html]
[test_dl_attributes_reflection.html]
[test_element_prototype.html]

49
dom/html/test/test_dialog_pref.html Normal file
View File

@ -0,0 +1,49 @@
<!DOCTYPE html>
<html>
<!--
https://bugzilla.mozilla.org/show_bug.cgi?id=dialog-element
-->
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Test dialog pref</title>
<script src="/tests/SimpleTest/SimpleTest.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
</head>
<body>
<a target="_blank"
href="https://bugzilla.mozilla.org/show_bug.cgi?id=dialog-element">Test dialog element pref</a>
<div id="testDiv">
</div>
<pre id="test">
<script class="testbody" type="text/javascript">
/** Test for dom.dialog_element.enabled **/
SimpleTest.waitForExplicitFinish();
function testPref() {
is(typeof HTMLDialogElement, "undefined",
"HTMLDialogElement should not be exposed with pref disabled");
info("Testing if createElement doesn't expose HTMLDialogElement with pref disabled");
let newElement = document.createElement("dialog");
testElement(newElement);
info("Testing if HTML Parser doesn't expose HTMLDialogElement with pref disabled");
let testDiv = document.getElementById("testDiv");
testDiv.innerHTML = "<dialog></dialog>";
testElement(testDiv.firstChild);
SimpleTest.finish();
}
function testElement(element) {
ok(element instanceof HTMLUnknownElement,
"New <dialog> should be instances of HTMLUnknownElement when pref is disabled");
}
addLoadEvent(testPref);
</script>
</pre>
</body>
</html>

2
dom/tests/mochitest/general/test_interfaces.js
View File

@ -462,7 +462,7 @@ var interfaceNamesInGlobalScope = [
// IMPORTANT: Do not change this list without review from a DOM peer!
{ name: "HTMLDetailsElement", insecureContext: true },
// IMPORTANT: Do not change this list without review from a DOM peer!
{ name: "HTMLDialogElement", insecureContext: true, nightly: true },
{ name: "HTMLDialogElement", insecureContext: true, disabled: true },
// IMPORTANT: Do not change this list without review from a DOM peer!
{ name: "HTMLDirectoryElement", insecureContext: true },
// IMPORTANT: Do not change this list without review from a DOM peer!

2
modules/libpref/init/StaticPrefList.yaml
View File

@ -1578,7 +1578,7 @@
# HTML <dialog> element
- name: dom.dialog_element.enabled
type: bool
value: @IS_NIGHTLY_BUILD@
value: false
mirror: always
# Only propagate the open window click permission if the setTimeout() is equal