Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-17 22:32:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1455763 - Remove SVGViewElement.viewTarget r=heycam r=mystor

Browse Source
This commit is contained in:
Robert Longson 2018-04-25 22:44:31 +01:00
parent cba47d4ae4
commit b0d2ba05a0
6 changed files with 1 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dom/svg/SVGFragmentIdentifier.cpp
View File

@ -110,7 +110,6 @@ public:
return false;
}
} else {
// We don't support viewTarget currently
return false;
}
return true;

22
dom/svg/SVGViewElement.cpp
View File

@ -6,7 +6,6 @@
#include "mozilla/dom/SVGViewElement.h"
#include "mozilla/dom/SVGViewElementBinding.h"
#include "DOMSVGStringList.h"
NS_IMPL_NS_NEW_NAMESPACED_SVG_ELEMENT(View)
@ -21,11 +20,6 @@ SVGViewElement::WrapNode(JSContext *aCx, JS::Handle<JSObject*> aGivenProto)
return SVGViewElementBinding::Wrap(aCx, this, aGivenProto);
}
nsSVGElement::StringListInfo SVGViewElement::sStringListInfo[1] =
{
{ &nsGkAtoms::viewTarget }
};
nsSVGEnumMapping SVGViewElement::sZoomAndPanMap[] = {
{&nsGkAtoms::disable, SVG_ZOOMANDPAN_DISABLE},
{&nsGkAtoms::magnify, SVG_ZOOMANDPAN_MAGNIFY},
@ -79,15 +73,6 @@ SVGViewElement::PreserveAspectRatio()
return mPreserveAspectRatio.ToDOMAnimatedPreserveAspectRatio(this);
}
//----------------------------------------------------------------------
already_AddRefed<DOMSVGStringList>
SVGViewElement::ViewTarget()
{
return DOMSVGStringList::GetDOMWrapper(
&mStringListAttributes[VIEW_TARGET], this, false, VIEW_TARGET);
}
//----------------------------------------------------------------------
// nsSVGElement methods
@ -110,12 +95,5 @@ SVGViewElement::GetPreserveAspectRatio()
return &mPreserveAspectRatio;
}
nsSVGElement::StringListAttributesInfo
SVGViewElement::GetStringListInfo()
{
return StringListAttributesInfo(mStringListAttributes, sStringListInfo,
ArrayLength(sStringListInfo));
}
} // namespace dom
} // namespace mozilla

7
dom/svg/SVGViewElement.h
View File

@ -47,7 +47,6 @@ public:
void SetZoomAndPan(uint16_t aZoomAndPan, ErrorResult& rv);
already_AddRefed<SVGAnimatedRect> ViewBox();
already_AddRefed<DOMSVGAnimatedPreserveAspectRatio> PreserveAspectRatio();
already_AddRefed<DOMSVGStringList> ViewTarget();
private:
@ -65,12 +64,6 @@ private:
nsSVGViewBox mViewBox;
SVGAnimatedPreserveAspectRatio mPreserveAspectRatio;
virtual StringListAttributesInfo GetStringListInfo() override;
enum { VIEW_TARGET };
SVGStringList mStringListAttributes[1];
static StringListInfo sStringListInfo[1];
};
} // namespace dom

1
dom/webidl/SVGViewElement.webidl
View File

@ -11,7 +11,6 @@
*/
interface SVGViewElement : SVGElement {
readonly attribute SVGStringList viewTarget;
};
SVGViewElement implements SVGFitToViewBox;

3
layout/svg/SVGViewFrame.cpp
View File

@ -91,8 +91,7 @@ SVGViewFrame::AttributeChanged(int32_t aNameSpaceID,
if (aNameSpaceID == kNameSpaceID_None &&
(aAttribute == nsGkAtoms::preserveAspectRatio ||
aAttribute == nsGkAtoms::viewBox ||
aAttribute == nsGkAtoms::viewTarget)) {
aAttribute == nsGkAtoms::viewBox)) {
nsSVGOuterSVGFrame *outerSVGFrame = nsSVGUtils::GetOuterSVGFrame(this);
NS_ASSERTION(outerSVGFrame->GetContent()->IsSVGElement(nsGkAtoms::svg),

3
testing/web-platform/meta/svg/historical.html.ini
View File

@ -17,6 +17,3 @@
[SVGSVGElement.prototype.useCurrentView must be removed]
expected: FAIL
[SVGViewElement.prototype.viewTarget must be removed]
expected: FAIL