Bug 1792861 - Fix ESLint no-unused-vars issues on global scopes in tests in extensions and toolkit. r=Gijs,application-update-reviewers,bytesized

Depends on D158347

Differential Revision: https://phabricator.services.mozilla.com/D158348

.eslintrc.js

@@ -180,12 +180,6 @@ module.exports = {
       // dependencies of bug 1612907.
       files: testPaths.xpcshell.map(path => `${path}test*.js`),
       excludedFiles: [
-        // These are suitable as good first bugs, take one or two related lines
-        // per bug.
-        "extensions/permissions/**",
-        "toolkit/crashreporter/test/unit/test_crash_AsyncShutdown.js",
-        "toolkit/mozapps/update/tests/unit_aus_update/testConstants.js",
-
         // These are more complicated bugs which may require some in-depth
         // investigation or different solutions. They are also likely to be
         // a reasonable size.

extensions/permissions/test/unit/test_permmanager_notifications.js

@@ -12,10 +12,6 @@ function run_test() {
   test_generator.next();
 }
 
-function continue_test() {
-  do_run_generator(test_generator);
-}
-
 function* do_run_test() {
   let pm = Services.perms;
   let now = Number(Date.now());

toolkit/crashreporter/test/unit/test_crash_AsyncShutdown.js

@@ -7,7 +7,6 @@
 // to import modules into each function.
 
 function setup_crash() {
-  /* global AsyncShutdown */
   const { AsyncShutdown } = ChromeUtils.import(
     "resource://gre/modules/AsyncShutdown.jsm"
   );

toolkit/mozapps/update/tests/unit_aus_update/testConstants.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */
 const REL_PATH_DATA = "";
 const URL_HOST = "http://127.0.0.1:8888";
 const URL_PATH_UPDATE_XML = "/" + REL_PATH_DATA + "app_update.sjs";