Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 08:15:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1597321 - Remove boolean result from Value::set operations r=jandem

Browse Source 
I don't know why these methods return a boolean, but I can't find any uses of it so I removed it.

Differential Revision: https://phabricator.services.mozilla.com/D53694

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Jon Coppeard 2019-11-19 07:21:46 +00:00
parent 8e6892faec
commit b1a0ebc87a
1 changed files with 17 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
js/public/Value.h
View File

@ -482,25 +482,23 @@ class alignas(8) Value {
MOZ_ASSERT(magicUint32() == payload);
}
bool setNumber(uint32_t ui) {
void setNumber(uint32_t ui) {
if (ui > JSVAL_INT_MAX) {
setDouble((double)ui);
return false;
} else {
setInt32((int32_t)ui);
return true;
return;
}
setInt32((int32_t)ui);
}
bool setNumber(double d) {
void setNumber(double d) {
int32_t i;
if (mozilla::NumberIsInt32(d, &i)) {
setInt32(i);
return true;
return;
}
setDouble(d);
return false;
}
void setObjectOrNull(JSObject* arg) {
@ -1195,8 +1193,8 @@ class MutableWrappedPtrOperations<JS::Value, Wrapper>
void setNaN() { setDouble(JS::GenericNaN()); }
void setBoolean(bool b) { value().setBoolean(b); }
void setMagic(JSWhyMagic why) { value().setMagic(why); }
bool setNumber(uint32_t ui) { return value().setNumber(ui); }
bool setNumber(double d) { return value().setNumber(d); }
void setNumber(uint32_t ui) { value().setNumber(ui); }
void setNumber(double d) { value().setNumber(d); }
void setString(JSString* str) { this->value().setString(str); }
void setSymbol(JS::Symbol* sym) { this->value().setSymbol(sym); }
void setBigInt(JS::BigInt* bi) { this->value().setBigInt(bi); }
@ -1236,33 +1234,32 @@ class HeapBase<JS::Value, Wrapper>
setBarriered(JS::PrivateGCThingValue(cell));
}
bool setNumber(uint32_t ui) {
void setNumber(uint32_t ui) {
if (ui > JSVAL_INT_MAX) {
setDouble((double)ui);
return false;
} else {
setInt32((int32_t)ui);
return true;
return;
}
setInt32((int32_t)ui);
}
bool setNumber(double d) {
void setNumber(double d) {
int32_t i;
if (mozilla::NumberIsInt32(d, &i)) {
setInt32(i);
return true;
return;
}
setDouble(d);
return false;
}
void setObjectOrNull(JSObject* arg) {
if (arg) {
setObject(*arg);
} else {
setNull();
return;
}
setNull();
}
};