Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 11:25:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 16516. Doh! Fix use of NS_RELEASE()-ed pointer that was causing load handlers to not run on brutally shared docs.

Browse Source
This commit is contained in:
waterson%netscape.com 1999-11-30 22:47:41 +00:00
parent 5f3b8fd9a2
commit b226f5a42a
2 changed files with 42 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
content/xul/document/src/nsXULDocument.cpp
View File

@ -2026,6 +2026,10 @@ nsXULDocument::CreateFromPrototype(const char* aCommand,
if (NS_FAILED(rv)) return rv;
{
// This scope restricts the lifetime of our reference to the
// loadgroup. Specifically, we don't want to have a reference
// to the load group on the stack when we call
// ResumeWalk().
nsCOMPtr<nsILoadGroup> loadgroup;
rv = nsComponentManager::CreateInstance(kLoadGroupCID,
nsnull,
@ -2033,15 +2037,23 @@ nsXULDocument::CreateFromPrototype(const char* aCommand,
getter_AddRefs(loadgroup));
if (NS_FAILED(rv)) return rv;
CachedChromeLoader* loader = new CachedChromeLoader(this);
if (! loader)
return NS_ERROR_OUT_OF_MEMORY;
// Create our own "document loader" that will fire the onload
// handlers when everything is finished. When this scope is
// closed, the loadgroup will be the only object with a
// reference to the loader.
nsCOMPtr<nsIStreamObserver> loader;
NS_ADDREF(loader);
nsCOMPtr<nsIStreamObserver> anchor = do_QueryInterface(loader, &rv);
NS_RELEASE(loader);
{
CachedChromeLoader* l = new CachedChromeLoader(this);
if (! l)
return NS_ERROR_OUT_OF_MEMORY;
if (NS_FAILED(rv)) return rv;
NS_ADDREF(l);
loader = do_QueryInterface(l, &rv);
NS_RELEASE(l);
if (NS_FAILED(rv)) return rv;
}
rv = loadgroup->Init(loader);
if (NS_FAILED(rv)) return rv;
@ -2057,7 +2069,8 @@ nsXULDocument::CreateFromPrototype(const char* aCommand,
if (NS_FAILED(rv)) return rv;
// Closing this scope will result in the placeholder channel
// being the only reference to the load group.
// created in PrepareToWalk() being the only reference to the
// load group.
}
rv = ResumeWalk();

29
rdf/content/src/nsXULDocument.cpp
View File

@ -2026,6 +2026,10 @@ nsXULDocument::CreateFromPrototype(const char* aCommand,
if (NS_FAILED(rv)) return rv;
{
// This scope restricts the lifetime of our reference to the
// loadgroup. Specifically, we don't want to have a reference
// to the load group on the stack when we call
// ResumeWalk().
nsCOMPtr<nsILoadGroup> loadgroup;
rv = nsComponentManager::CreateInstance(kLoadGroupCID,
nsnull,
@ -2033,15 +2037,23 @@ nsXULDocument::CreateFromPrototype(const char* aCommand,
getter_AddRefs(loadgroup));
if (NS_FAILED(rv)) return rv;
CachedChromeLoader* loader = new CachedChromeLoader(this);
if (! loader)
return NS_ERROR_OUT_OF_MEMORY;
// Create our own "document loader" that will fire the onload
// handlers when everything is finished. When this scope is
// closed, the loadgroup will be the only object with a
// reference to the loader.
nsCOMPtr<nsIStreamObserver> loader;
NS_ADDREF(loader);
nsCOMPtr<nsIStreamObserver> anchor = do_QueryInterface(loader, &rv);
NS_RELEASE(loader);
{
CachedChromeLoader* l = new CachedChromeLoader(this);
if (! l)
return NS_ERROR_OUT_OF_MEMORY;
if (NS_FAILED(rv)) return rv;
NS_ADDREF(l);
loader = do_QueryInterface(l, &rv);
NS_RELEASE(l);
if (NS_FAILED(rv)) return rv;
}
rv = loadgroup->Init(loader);
if (NS_FAILED(rv)) return rv;
@ -2057,7 +2069,8 @@ nsXULDocument::CreateFromPrototype(const char* aCommand,
if (NS_FAILED(rv)) return rv;
// Closing this scope will result in the placeholder channel
// being the only reference to the load group.
// created in PrepareToWalk() being the only reference to the
// load group.
}
rv = ResumeWalk();