Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-13 05:15:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix for #33310 - weakref leaks

Browse Source 
r=bruce
thanks to beard for finding this broken pattern
This commit is contained in:
alecf%netscape.com 2000-03-25 20:41:26 +00:00
parent dfc365a5f0
commit b24823cbbd
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mailnews/base/util/nsMessage.cpp
View File

@ -539,7 +539,7 @@ NS_IMETHODIMP nsMessage::GetMsgFolder(nsIMsgFolder **aFolder)
NS_IMETHODIMP nsMessage::SetMsgFolder(nsIMsgFolder *folder) NS_IMETHODIMP nsMessage::SetMsgFolder(nsIMsgFolder *folder)
{ {
mFolder = NS_GetWeakReference(folder); mFolder = getter_AddRefs(NS_GetWeakReference(folder));
return NS_OK; return NS_OK;
} }

5
mailnews/base/util/nsMsgFolder.cpp
View File

@ -349,7 +349,8 @@ NS_IMETHODIMP nsMsgFolder::RemoveFolderListener(nsIFolderListener * listener)
NS_IMETHODIMP nsMsgFolder::SetParent(nsIFolder *aParent) NS_IMETHODIMP nsMsgFolder::SetParent(nsIFolder *aParent)
{ {
mParent = NS_GetWeakReference(aParent); mParent = getter_AddRefs(NS_GetWeakReference(aParent));
return NS_OK; return NS_OK;
} }
@ -556,7 +557,7 @@ nsMsgFolder::parseURI(PRBool needServer)
} }
mServer = NS_GetWeakReference(server); mServer = getter_AddRefs(NS_GetWeakReference(server));
} /* !mServer */ } /* !mServer */

2
mailnews/base/util/nsMsgIdentity.cpp
View File

@ -441,7 +441,7 @@ nsMsgIdentity::SetSmtpServer(nsISmtpServer *aServer)
{ {
nsresult rv; nsresult rv;
m_smtpServer = NS_GetWeakReference(aServer, &rv); m_smtpServer = getter_AddRefs(NS_GetWeakReference(aServer, &rv));
if (aServer) { if (aServer) {
nsXPIDLCString smtpServerKey; nsXPIDLCString smtpServerKey;