Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-23 02:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1554982 - Make console filter input use filter icon. r=nchevobbe

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D32829

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Tim Nguyen 2019-05-29 14:36:13 +00:00
parent ac14a7e160
commit b2ca59ade9
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
devtools/client/shared/components/SearchBox.js
View File

@ -191,7 +191,7 @@ class SearchBox extends PureComponent {
placeholder, placeholder,
ref: this.inputRef, ref: this.inputRef,
value, value,
type, type: "search",
}), }),
showLearnMoreLink && MDNLink({ showLearnMoreLink && MDNLink({
title: learnMoreTitle, title: learnMoreTitle,

1
devtools/client/webconsole/components/FilterBar.js
View File

@ -248,6 +248,7 @@ class FilterBar extends Component {
className: "devtools-separator", className: "devtools-separator",
}), }),
SearchBox({ SearchBox({
type: "filter",
placeholder: l10n.getStr("webconsole.filterInput.placeholder"), placeholder: l10n.getStr("webconsole.filterInput.placeholder"),
keyShortcut: l10n.getStr("webconsole.find.key"), keyShortcut: l10n.getStr("webconsole.find.key"),
onChange: this.onSearchBoxChange, onChange: this.onSearchBoxChange,

4
devtools/client/webconsole/test/components/filter-bar.test.js
View File

@ -58,7 +58,7 @@ describe("FilterBar component:", () => {
// Text filter input // Text filter input
const textFilter = textInput.children().eq(0); const textFilter = textInput.children().eq(0);
expect(textFilter.attr("class")).toBe("devtools-searchinput"); expect(textFilter.attr("class")).toBe("devtools-filterinput");
expect(textFilter.attr("placeholder")).toBe("Filter output"); expect(textFilter.attr("placeholder")).toBe("Filter output");
expect(textFilter.attr("type")).toBe("search"); expect(textFilter.attr("type")).toBe("search");
expect(textFilter.attr("value")).toBe(""); expect(textFilter.attr("value")).toBe("");
@ -251,7 +251,7 @@ describe("FilterBar component:", () => {
const store = setupStore(); const store = setupStore();
const wrapper = mount(Provider({store}, getFilterBar())); const wrapper = mount(Provider({store}, getFilterBar()));
const input = wrapper.find(".devtools-searchinput"); const input = wrapper.find(".devtools-filterinput");
input.simulate("change", { target: { value: "a" } }); input.simulate("change", { target: { value: "a" } });
expect(store.getState().filters.text).toBe("a"); expect(store.getState().filters.text).toBe("a");
}); });