servo: Merge #11293 - Remove the pointless StorageThread alias (from Ms2ger:StorageThread); r=KiChjang

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

Source-Repo: https://github.com/servo/servo
Source-Revision: a8d28771f8e931d826c0115d483d59b7861fee47

servo/components/net/storage_thread.rs

@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 use ipc_channel::ipc::{self, IpcReceiver, IpcSender};
-use net_traits::storage_thread::{StorageThread, StorageThreadMsg, StorageType};
+use net_traits::storage_thread::{StorageThreadMsg, StorageType};
 use resource_thread;
 use std::borrow::ToOwned;
 use std::collections::BTreeMap;
@@ -18,9 +18,9 @@ pub trait StorageThreadFactory {
     fn new() -> Self;
 }
 
-impl StorageThreadFactory for StorageThread {
-    /// Create a StorageThread
-    fn new() -> StorageThread {
+impl StorageThreadFactory for IpcSender<StorageThreadMsg> {
+    /// Create a storage thread
+    fn new() -> IpcSender<StorageThreadMsg> {
         let (chan, port) = ipc::channel().unwrap();
         spawn_named("StorageManager".to_owned(), move || {
             StorageManager::new(port).start();

servo/components/net_traits/lib.rs

@@ -38,7 +38,7 @@ use msg::constellation_msg::{PipelineId, ReferrerPolicy};
 use std::io::Error as IOError;
 use std::sync::mpsc::Sender;
 use std::thread;
-use storage_thread::{StorageThread, StorageThreadMsg};
+use storage_thread::StorageThreadMsg;
 use url::Url;
 use websocket::header;
 
@@ -199,11 +199,11 @@ pub trait IpcSend<T> where T: serde::Serialize + serde::Deserialize {
 #[derive(Clone, Serialize, Deserialize)]
 pub struct ResourceThreads {
     core_thread: CoreResourceThread,
-    storage_thread: StorageThread,
+    storage_thread: IpcSender<StorageThreadMsg>,
 }
 
 impl ResourceThreads {
-    pub fn new(c: CoreResourceThread, s: StorageThread) -> ResourceThreads {
+    pub fn new(c: CoreResourceThread, s: IpcSender<StorageThreadMsg>) -> ResourceThreads {
         ResourceThreads {
             core_thread: c,
             storage_thread: s,

servo/components/net_traits/storage_thread.rs

@@ -38,8 +38,3 @@ pub enum StorageThreadMsg {
     /// shut down this thread
     Exit
 }
-
-/// Handle to a storage thread
-pub type StorageThread = IpcSender<StorageThreadMsg>;
-
-

servo/components/script/dom/storage.rs

@@ -14,9 +14,9 @@ use dom::browsingcontext::IterableContext;
 use dom::event::{Event, EventBubbles, EventCancelable};
 use dom::storageevent::StorageEvent;
 use dom::urlhelper::UrlHelper;
-use ipc_channel::ipc;
+use ipc_channel::ipc::{self, IpcSender};
 use net_traits::IpcSend;
-use net_traits::storage_thread::{StorageThread, StorageThreadMsg, StorageType};
+use net_traits::storage_thread::{StorageThreadMsg, StorageType};
 use script_thread::{MainThreadRunnable, ScriptThread};
 use task_source::dom_manipulation::DOMManipulationTask;
 use url::Url;
@@ -46,7 +46,7 @@ impl Storage {
         global_ref.get_url()
     }
 
-    fn get_storage_thread(&self) -> StorageThread {
+    fn get_storage_thread(&self) -> IpcSender<StorageThreadMsg> {
         let global_root = self.global();
         let global_ref = global_root.r();
         global_ref.as_window().resource_threads().sender()