Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-02 01:48:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 289012: Can't use an undefined value as a HASH reference at userprefs.cgi line 142.

Browse Source 
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave
This commit is contained in:
mkanat%kerio.com 2005-04-27 16:00:25 +00:00
parent ea186dd056
commit b3a290df01
2 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webtools/bugzilla/Bugzilla/User/Setting.pm
View File

@ -127,7 +127,7 @@ sub add_setting {
sub get_all_settings {
my ($user_id) = @_;
my $settings;
my $settings = {};
my $dbh = Bugzilla->dbh;
my $sth = $dbh->prepare(
@ -162,7 +162,7 @@ sub get_all_settings {
sub get_defaults {
my $dbh = Bugzilla->dbh;
my $default_settings;
my $default_settings = {};
my $sth = $dbh->prepare(q{SELECT name, default_value, is_enabled
FROM setting

24
webtools/bugzilla/checksetup.pl
View File

@ -84,6 +84,7 @@
# add more database-related checks --DATABASE--
# change table definitions --TABLE--
# add more groups --GROUPS--
# add user-adjustable sttings --SETTINGS--
# create initial administrator account --ADMIN--
#
# Note: sometimes those special comments occur more than once. For
@ -3772,9 +3773,6 @@ if($dbh->bz_column_info('bugs', 'lastdiffed')->{NOTNULL}) {
$dbh->bz_alter_column('bugs', 'lastdiffed', {TYPE => 'DATETIME'});
}
# 2005-03-03 travis@sedsystems.ca -- Bug 41972
add_setting ("display_quips", {"on" => 1, "off" => 2 }, "on" );
# 2005-03-09 qa_contact should be NULL instead of 0, bug 285534
if ($dbh->bz_column_info('bugs', 'qa_contact')->{NOTNULL}) {
$dbh->bz_alter_column('bugs', 'qa_contact', {TYPE => 'INT3'});
@ -3923,13 +3921,6 @@ if ( $dbh->isa('Bugzilla::DB::Mysql') ) {
}
}
# 2005-03-10 travis@sedsystems.ca -- Bug 199048
add_setting ("comment_sort_order", {"oldest_to_newest" => 1,
"newest_to_oldest" => 2,
"newest_to_oldest_desc_first" => 3},
"oldest_to_newest" );
# 2005-04-07 - alt@sonic.net, bug 289455
# make classification_id field type be consistent with DB:Schema
$dbh->bz_alter_column('products', 'classification_id',
@ -4010,6 +4001,19 @@ if (!GroupDoesExist('bz_canusewhines')) {
GROUP_MEMBERSHIP . ")") unless $group_exists;
}
###########################################################################
# Create --SETTINGS-- users can adjust
###########################################################################
# 2005-03-03 travis@sedsystems.ca -- Bug 41972
add_setting ("display_quips", {"on" => 1, "off" => 2 }, "on" );
# 2005-03-10 travis@sedsystems.ca -- Bug 199048
add_setting ("comment_sort_order", {"oldest_to_newest" => 1,
"newest_to_oldest" => 2,
"newest_to_oldest_desc_first" => 3},
"oldest_to_newest" );
###########################################################################
# Create Administrator --ADMIN--
###########################################################################