Bug 1554589 - Turn nsCharsetSource constants into an enum. r=hsivonen

Since unscoped enums implicitly convert to underlying types, we don't have to change everything at once. It is worth enough to introduce auto-numbering, IMO.

Differential Revision: https://phabricator.services.mozilla.com/D32841

--HG--
extra : moz-landing-system : lando

parser/nsCharsetSource.h

@@ -6,24 +6,26 @@
 #define nsCharsetSource_h_
 
 // note: the value order defines the priority; higher numbers take priority
-#define kCharsetUninitialized 0
-#define kCharsetFromFallback 1
-#define kCharsetFromTopLevelDomain 2
-#define kCharsetFromFileURLGuess 3
-#define kCharsetFromDocTypeDefault 4  // This and up confident for XHR
-#define kCharsetFromCache 5
-#define kCharsetFromParentFrame 6
-#define kCharsetFromAutoDetection 7
-#define kCharsetFromHintPrevDoc 8
-#define kCharsetFromMetaPrescan 9  // this one and smaller: HTML5 Tentative
-#define kCharsetFromMetaTag 10     // this one and greater: HTML5 Confident
-#define kCharsetFromIrreversibleAutoDetection 11
-#define kCharsetFromChannel 12
-#define kCharsetFromOtherComponent 13
-#define kCharsetFromParentForced 14  // propagates to child frames
-#define kCharsetFromUserForced 15    // propagates to child frames
-#define kCharsetFromByteOrderMark 16
-#define kCharsetFromUtf8OnlyMime 17  // For JSON, WebVTT and such
-#define kCharsetFromBuiltIn 18       // resource: URLs
+enum {
+  kCharsetUninitialized,
+  kCharsetFromFallback,
+  kCharsetFromTopLevelDomain,
+  kCharsetFromFileURLGuess,
+  kCharsetFromDocTypeDefault,  // This and up confident for XHR
+  kCharsetFromCache,
+  kCharsetFromParentFrame,
+  kCharsetFromAutoDetection,
+  kCharsetFromHintPrevDoc,
+  kCharsetFromMetaPrescan,  // this one and smaller: HTML5 Tentative
+  kCharsetFromMetaTag,      // this one and greater: HTML5 Confident
+  kCharsetFromIrreversibleAutoDetection,
+  kCharsetFromChannel,
+  kCharsetFromOtherComponent,
+  kCharsetFromParentForced,  // propagates to child frames
+  kCharsetFromUserForced,    // propagates to child frames
+  kCharsetFromByteOrderMark,
+  kCharsetFromUtf8OnlyMime,  // For JSON, WebVTT and such
+  kCharsetFromBuiltIn,       // resource: URLs
+};
 
 #endif /* nsCharsetSource_h_ */