Bug 1722456 - [devtools] Update documentation to find Devtools reviewers r=Honza

Differential Revision: https://phabricator.services.mozilla.com/D121524
This commit is contained in:
Julian Descottes 2021-08-02 14:14:22 +00:00
parent b919f6cd51
commit b44277e02b
2 changed files with 5 additions and 7 deletions

View File

@ -1,7 +1,5 @@
# Finding suitable reviewers
The code in DevTools is divided into modules (because there's just so much code it's impossible for one person to know *everything* off the top of their head).
There are several options to find a good reviewer for a patch. If the bug you are working on is mentored, assign the review to the mentor. Otherwise, assign it to the triage owner (visible in the "People" section of a Bug in Bugzilla).
Each module has one or more "owners", who know a lot about it. And they're the people you want to ask to review your code 😀
You might already know who is the reviewer (perhaps the person that is mentoring the bug, perhaps your team mate), but in case of doubt, you can [consult this list of people and modules](https://firefox-dev.tools/#people-and-modules).
Finally, an easy option is to use the #devtools-reviewers group in Phabricator.

View File

@ -40,9 +40,9 @@ Review groups
* - #dom-workers-and-storage-reviewers
- DOM Workers & Storage
- `Member list <https://phabricator.services.mozilla.com/project/members/115/>`__
* - #devtools-inspector-reviewers
- The devtools inspector tool
- `Member list <https://phabricator.services.mozilla.com/project/members/109/>`__
* - #devtools-reviewers
- Firefox DevTools
- `Member list <https://phabricator.services.mozilla.com/project/members/153/>`__
* - #fluent-reviewers
- Changes to Fluent (FTL) files (translation).
- `Member list <https://phabricator.services.mozilla.com/project/members/105/>`__