Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-07 11:56:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix bad string comparison preventing 'none' and 'initial' values of 'counter-increment' and 'counter-reset' from being parsed correctly. b=379555 r+sr=dbaron Patch by Daniel Holbert <dholbert@mozilla.com>.

Browse Source
This commit is contained in:
dbaron@dbaron.org 2007-05-03 17:05:16 -07:00
parent 2f2d420a70
commit b48962a233
3 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
layout/style/nsCSSParser.cpp
View File

@ -5455,7 +5455,7 @@ PRBool CSSParserImpl::ParseCounterData(nsresult& aErrorCode,
for (const SingleCounterPropValue *sv = singleValues, for (const SingleCounterPropValue *sv = singleValues,
*sv_end = singleValues + NS_ARRAY_LENGTH(singleValues); *sv_end = singleValues + NS_ARRAY_LENGTH(singleValues);
sv != sv_end; ++sv) { sv != sv_end; ++sv) {
if (ident->LowerCaseEqualsLiteral(sv->str)) { if (ident->LowerCaseEqualsASCII(sv->str)) {
if (ExpectEndProperty(aErrorCode, PR_TRUE)) { if (ExpectEndProperty(aErrorCode, PR_TRUE)) {
nsCSSCounterData* dataHead = new nsCSSCounterData(); nsCSSCounterData* dataHead = new nsCSSCounterData();
if (!dataHead) { if (!dataHead) {

4
layout/style/test/test_inherit_computation.html
View File

@ -75,10 +75,6 @@ var gBrokenInherit = {
"-moz-border-left-colors": true, "-moz-border-left-colors": true,
"-moz-border-right-colors": true, "-moz-border-right-colors": true,
"-moz-border-top-colors": true, "-moz-border-top-colors": true,
// Parses inherit as a counter name
"counter-increment": true,
"counter-reset": true,
}; };
function xfail_inherit(property, matching_initial) { function xfail_inherit(property, matching_initial) {

4
layout/style/test/test_value_computation.html
View File

@ -107,10 +107,6 @@ var gBadComputed = {
"clip": [ "rect(auto,auto,auto,auto)" ], "clip": [ "rect(auto,auto,auto,auto)" ],
// This seems really broken! // This seems really broken!
"counter-increment": [ "none" ],
"counter-reset": [ "none" ],
// So does this.
"marker-offset": [ "auto" ], "marker-offset": [ "auto" ],
// No idea what's happening for these two either // No idea what's happening for these two either