From b50a1dda798ab2844f74f65c238554073b372563 Mon Sep 17 00:00:00 2001 From: Rune Lillesveen Date: Tue, 6 Aug 2019 17:23:42 +0000 Subject: [PATCH] Bug 1570618 [wpt PR 18232] - Use To for rebuild root to make sure we don't crash., a=testonly Automatic update from web-platform-tests Use To for rebuild root to make sure we don't crash. We were able to SetNeedsReattachLayoutTree() on a Text node where none of the ancestor elements had a LayoutObject and the Document had a
as a documentElement. The reason is that LayoutView does not allow a LayoutBr child which meant we recomputed styles for the whole subtree, but no LayoutObjects were created. Setting the text data on the text node would mark it for re-attachment (in case it didn't have a LayoutText because it used to be a non-rendered white-space). If it was in a display:none subtree we wouldn't have reached the text node during recalc, but because of LayoutView rejecting the LayoutBr, we already had ComputedStyle all the way. Bug: 989827 Change-Id: I72ae371466e607baf4caffad9ed634beb2a66bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731112 Reviewed-by: Anders Hartvoll Ruud Commit-Queue: Rune Lillesveen Cr-Commit-Position: refs/heads/master@{#683135} -- wpt-commits: ec90c902eeb0612dbce30047ff51414c8b26d603 wpt-pr: 18232 --- ...re-line-br-with-whitespace-child-crash.html | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 testing/web-platform/tests/css/css-text/white-space/pre-line-br-with-whitespace-child-crash.html diff --git a/testing/web-platform/tests/css/css-text/white-space/pre-line-br-with-whitespace-child-crash.html b/testing/web-platform/tests/css/css-text/white-space/pre-line-br-with-whitespace-child-crash.html new file mode 100644 index 000000000000..c7e1855f9794 --- /dev/null +++ b/testing/web-platform/tests/css/css-text/white-space/pre-line-br-with-whitespace-child-crash.html @@ -0,0 +1,18 @@ + +CSS Text Test: Chrome pre-line crash test + + + + +