Bug 1931575 - Run the test-manifest-toml linter on CI. r=jmaher

Differential Revision: https://phabricator.services.mozilla.com/D229167

dom/quota/test/xpcshell/telemetry/xpcshell.toml

@@ -14,7 +14,10 @@ support-files = [
 ]
 
 ["test_dom_quota_try.js"]
-skip-if = ["os == 'android' || appname == 'thunderbird'"]
+skip-if = [
+  "os == 'android'",
+  "appname == 'thunderbird'",
+]
 
 ["test_qm_first_initialization_attempt.js"]
 skip-if = ["appname == 'thunderbird'"]

dom/serviceworkers/test/browser-common.toml

@@ -59,6 +59,7 @@ skip-if = ["true"] # Crashes: @ mozilla::dom::ServiceWorkerManagerService::Propa
 
 ["browser_storage_recovery.js"]
 
-#["browser_sw_lifetime_extension.js"]
+["browser_sw_lifetime_extension.js"]
+disabled = "Pending re-enabling, remove from browser.toml when enabled."
 
 ["browser_unregister_with_containers.js"]

taskcluster/kinds/source-test/mozlint.yml

@@ -318,7 +318,7 @@ test-manifest:
     treeherder:
         symbol: misc(tm)
     run:
-        mach: lint -v -l test-manifest-alpha -l test-manifest-disable -l test-manifest-skip-if -f treeherder -f json:/builds/worker/mozlint.json .
+        mach: lint -v -l test-manifest-alpha -l test-manifest-disable -l test-manifest-skip-if -l test-manifest-toml -f treeherder -f json:/builds/worker/mozlint.json .
     when:
         files-changed:
             - '**/*.toml'

testing/mochitest/tests/browser/browser.toml

@@ -3,100 +3,100 @@ support-files = [
   "head.js",
   "dummy.html"]
 
-['browser_BrowserTestUtils.js']
+["browser_BrowserTestUtils.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_add_task.js']
+["browser_add_task.js"]
 
-['browser_async.js']
+["browser_async.js"]
 
-['browser_browserLoaded_content_loaded.js']
+["browser_browserLoaded_content_loaded.js"]
 https_first_disabled = true
 
-['browser_document_builder_sjs.js']
+["browser_document_builder_sjs.js"]
 
-['browser_fail.js']
+["browser_fail.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_fail_add_task.js']
+["browser_fail_add_task.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_fail_add_task_uncaught_rejection.js']
+["browser_fail_add_task_uncaught_rejection.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_fail_async.js']
+["browser_fail_async.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_fail_if.js']
-fail-if = true
+["browser_fail_if.js"]
+fail-if = ["true"]
 
-['browser_fail_throw.js']
+["browser_fail_throw.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_fail_timeout.js']
-skip-if = true # Disabled beacuse it takes too long (bug 1178959)
+["browser_fail_timeout.js"]
+disabled = "Disabled beacuse it takes too long (bug 1178959)"
 
-['browser_fail_uncaught_rejection.js']
+["browser_fail_uncaught_rejection.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_fail_uncaught_rejection_expected.js']
+["browser_fail_uncaught_rejection_expected.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_fail_uncaught_rejection_expected_multi.js']
+["browser_fail_uncaught_rejection_expected_multi.js"]
 skip-if = [
   "verify",
 ]
 
-['browser_fail_unexpectedTimeout.js']
-skip-if = true # Disabled beacuse it takes too long (bug 1178959)
+["browser_fail_unexpectedTimeout.js"]
+disabled = "Disabled beacuse it takes too long (bug 1178959)"
 
-['browser_getTestFile.js']
+["browser_getTestFile.js"]
 support-files = [
   "test-dir/*",
   "waitForFocusPage.html"]
 
-['browser_head.js']
+["browser_head.js"]
 
-['browser_parameters.js']
+["browser_parameters.js"]
 
-['browser_pass.js']
+["browser_pass.js"]
 
-['browser_privileges.js']
+["browser_privileges.js"]
 
-['browser_requestLongerTimeout.js']
-skip-if = true # Disabled beacuse it takes too long (bug 1178959)
+["browser_requestLongerTimeout.js"]
+disabled = "Disabled beacuse it takes too long (bug 1178959)"
 
-['browser_sanityException.js']
+["browser_sanityException.js"]
 
-['browser_sanityException2.js']
+["browser_sanityException2.js"]
 
-['browser_setup_runs_first.js']
+["browser_setup_runs_first.js"]
 
-['browser_setup_runs_for_only_tests.js']
+["browser_setup_runs_for_only_tests.js"]
 
-['browser_tasks_skip.js']
+["browser_tasks_skip.js"]
 
-['browser_tasks_skipall.js']
+["browser_tasks_skipall.js"]
 
-['browser_uncaught_rejection_expected.js']
+["browser_uncaught_rejection_expected.js"]
 
-['browser_waitForFocus.js']
+["browser_waitForFocus.js"]
 
-['browser_zz_fail_openwindow.js']
-skip-if = true # this catches outside of the main loop to find an extra window
+["browser_zz_fail_openwindow.js"]
+disabled = "this catches outside of the main loop to find an extra window"

toolkit/components/ml/tests/browser/perftest.toml

@@ -3,14 +3,14 @@ support-files = [
     "head.js",
 ]
 
+["browser_ml_engine_multi_perf.js"]
+disabled = "Disabled as we want to run this only as perftest, not regular CI"
+
 ["browser_ml_engine_perf.js"]
-skip-if = true # Disabled as we want to run this only as perftest, not regular CI
+disabled = "Disabled as we want to run this only as perftest, not regular CI"
 
 ["browser_ml_suggest_intent_perf.js"]
-skip-if = true # Disabled as we want to run this only as perftest, not regular CI
+disabled = "Disabled as we want to run this only as perftest, not regular CI"
 
 ["browser_ml_suggest_ner_perf.js"]
-skip-if = true # Disabled as we want to run this only as perftest, not regular CI
-
-["browser_ml_engine_multi_perf.js"]
-skip-if = true # Disabled as we want to run this only as perftest, not regular CI
+disabled = "Disabled as we want to run this only as perftest, not regular CI"

tools/lint/test-manifest-toml.yml

@@ -2,10 +2,14 @@
 test-manifest-toml:
     description: ManifestParser TOML linter.
     exclude:
+        - 'dom/canvas/test/webgl-conf/mochitest-errata.toml'
         - 'intl/icu/source/test/testdata/codepointtrie/'
         - 'python/mozbuild/mozbuild/test/'
+        - 'mobile/android/bors.toml'
+        - 'mobile/android/fenix/bors.toml'
         - 'testing/marionette/harness/marionette_harness/tests/unit-tests.toml'
         - 'testing/mozbase/manifestparser/tests/'
+        - 'testing/raptor/raptor/tests/'
         - 'third_party/rust/'
         - 'toolkit/components/featuregates/test/python/data/'
         - '**/.*ruff.toml'

xpcom/tests/unit/xpcshell.toml

@@ -59,7 +59,7 @@ fail-if = ["os == 'android'"]
 ["test_localfile.js"]
 
 ["test_logFromPreference.js"]
-skip-if = "(os == 'android' && release_or_beta)" # bug 1841818
+skip-if = ["(os == 'android' && release_or_beta)"] # bug 1841818
 
 ["test_mac_bundle.js"]