Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-17 23:35:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1708235 - Remove broken console-instant-eval test r=evilpie

Browse Source 
This test was added in Bug 1651420, and then broken silently, due to an error
in the activation of the test by Bug 1653567. This edge case behaviour
shouldn't block us from landing private fields and methods

Tracking fixing this I have opened Bug 1708812.

Differential Revision: https://phabricator.services.mozilla.com/D114016
This commit is contained in:
Matthew Gaudet 2021-04-30 20:42:09 +00:00
parent c0e2fc047e
commit b58d822874
2 changed files with 0 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
devtools/server/tests/xpcshell/test_console_eval-private.js
View File

@ -1,40 +0,0 @@
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
/*
* Check that private field initialization is marked as effectful.
*/
add_task(
threadFrontTest(async ({ threadFront, targetFront, debuggee }) => {
const consoleFront = await targetFront.getFront("console");
const initial_response = await consoleFront.evaluateJSAsync(`
// This is a silly trick that allows stamping a field into
// arbitrary objects.
class Base { constructor(o) { return o; }};
class A extends Base {
#x = 10;
};
var obj = {};
`);
// If an exception occurred, private fields are not yet enabled. Abort
// the rest of this test.
if (initial_response.hasException) {
return;
}
const eagerResult = await consoleFront.evaluateJSAsync("new A(obj)", {
eager: true,
});
Assert.equal(
eagerResult.result.type,
"undefined",
"shouldn't have actually produced a result"
);
const timeoutResult = await consoleFront.evaluateJSAsync("new A(obj); 1;");
Assert.equal(timeoutResult.result, 1, "normal eval, no throw.");
})
);

1
devtools/server/tests/xpcshell/xpcshell.ini
View File

@ -123,7 +123,6 @@ skip-if = true # breakpoint sliding is not supported bug 1525685
[test_conditional_breakpoint-04.js]
[test_console_eval-01.js]
[test_console_eval-02.js]
[test_console_eval-private.js]
[test_logpoint-01.js]
[test_logpoint-02.js]
[test_logpoint-03.js]