Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-13 13:25:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix for bug 94618: remove restrictions on valid characters in passwords. If crypt() takes it, why shouldn't we?

Browse Source 
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
This commit is contained in:
justdave%syndicomm.com 2001-08-11 01:51:05 +00:00
parent 1d7cc61564
commit b5d9a45521
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
webtools/bugzilla/checksetup.pl
View File

@ -1508,9 +1508,8 @@ _End_Of_SQL_
chomp $pass1;
if(! $pass1 ) {
print "\n\nIt's just plain stupid to not have a password. Try again!\n";
} elsif ( $pass1 !~ /^[a-zA-Z0-9-_]{3,16}$/ ) {
print "The password must be 3-16 characters in length
and contain only letters, numbers, hyphens (-), and underlines (_).";
} elsif ( $pass1 !~ /^.{3,16}$/ ) {
print "The password must be 3-16 characters in length.";
}
}
print "\nPlease retype the password to verify: ";

11
webtools/bugzilla/globals.pl
View File

@ -658,10 +658,9 @@ sub GenerateRandomPassword {
# Generated passwords are eight characters long by default.
$size ||= 8;
# The list of characters that can appear in a password.
# If you change this you must also update &ValidatePassword below.
my @pwchars = (0..9, 'A'..'Z', 'a'..'z', '-', '_');
#my @pwchars = (0..9, 'A'..'Z', 'a'..'z', '-', '_', '!', '@', '#', '$', '%', '^', '&', '*');
# The list of characters that can appear in a randomly generated password.
# Note that users can put any character into a password they choose themselves.
my @pwchars = (0..9, 'A'..'Z', 'a'..'z', '-', '_', '!', '@', '#', '$', '%', '^', '&', '*');
# The number of characters in the list.
my $pwcharslen = scalar(@pwchars);
@ -688,9 +687,7 @@ sub ValidatePassword {
my ($password, $matchpassword) = @_;
if ( $password !~ /^[a-zA-Z0-9-_]*$/ ) {
return "The password contains an illegal character. Legal characters are letters, numbers, hyphens (-), and underlines (_).";
} elsif ( length($password) < 3 ) {
if ( length($password) < 3 ) {
return "The password is less than three characters long. It must be at least three characters.";
} elsif ( length($password) > 16 ) {
return "The password is more than 16 characters long. It must be no more than 16 characters.";