Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-18 15:55:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1489569 - 1. Avoid unnecessary setActive calls; r=droeh

Browse Source 
To avoid unnecessary setActive calls, only call it when we have a
display and when the display acquires or releases a surface. In other
cases, we can delay the setActive call until later.

Differential Revision: https://phabricator.services.mozilla.com/D5328
This commit is contained in:
Jim Chen 2018-09-10 12:42:34 -04:00
parent 67945694c1
commit b5db081f11
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoView.java
View File

@ -111,8 +111,8 @@ public class GeckoView extends FrameLayout {
final SurfaceHolder holder = GeckoView.this.mSurfaceView.getHolder();
final Rect frame = holder.getSurfaceFrame();
mDisplay.surfaceChanged(holder.getSurface(), frame.right, frame.bottom);
GeckoView.this.setActive(true);
}
GeckoView.this.setActive(true);
}
public GeckoDisplay release() {
@ -135,8 +135,10 @@ public class GeckoView extends FrameLayout {
final int width, final int height) {
if (mDisplay != null) {
mDisplay.surfaceChanged(holder.getSurface(), width, height);
if (!mValid) {
GeckoView.this.setActive(true);
}
}
GeckoView.this.setActive(true);
mValid = true;
}
@ -144,8 +146,8 @@ public class GeckoView extends FrameLayout {
public void surfaceDestroyed(final SurfaceHolder holder) {
if (mDisplay != null) {
mDisplay.surfaceDestroyed();
GeckoView.this.setActive(false);
}
GeckoView.this.setActive(false);
mValid = false;
}