Backed out changeset 6c865ed1f998 (bug 1641389) for perma failures on test_animation_operators.html. CLOSED TREE

image/DecoderFactory.cpp

@@ -7,7 +7,6 @@
 
 #include "nsMimeTypes.h"
 #include "mozilla/RefPtr.h"
-#include "mozilla/StaticPrefs_image.h"
 
 #include "AnimationSurfaceProvider.h"
 #include "Decoder.h"
@@ -77,7 +76,8 @@ DecoderType DecoderFactory::GetDecoderType(const char* aMimeType) {
     type = DecoderType::ICON;
 
     // WebP
-  } else if (!strcmp(aMimeType, IMAGE_WEBP)) {
+  } else if (!strcmp(aMimeType, IMAGE_WEBP) &&
+             StaticPrefs::image_webp_enabled()) {
     type = DecoderType::WEBP;
 
     // AVIF

image/build/nsImageModule.cpp

@@ -58,8 +58,13 @@ nsresult mozilla::image::EnsureModuleInitialized() {
   static ImageEnablementCookie kAVIFCookie = {
       mozilla::StaticPrefs::image_avif_enabled,
       NS_LITERAL_CSTRING("image/avif")};
+  static ImageEnablementCookie kWebPCookie = {
+      mozilla::StaticPrefs::image_webp_enabled,
+      NS_LITERAL_CSTRING("image/webp")};
   Preferences::RegisterCallbackAndCall(UpdateContentViewerRegistration,
                                        "image.avif.enabled", &kAVIFCookie);
+  Preferences::RegisterCallbackAndCall(UpdateContentViewerRegistration,
+                                       "image.webp.enabled", &kWebPCookie);
 
   mozilla::image::ShutdownTracker::Initialize();
   mozilla::image::ImageFactory::Initialize();

image/test/gtest/Common.cpp

@@ -36,8 +36,12 @@ AutoInitializeImageLib::AutoInitializeImageLib() {
   EXPECT_TRUE(NS_IsMainThread());
   sImageLibInitialized = true;
 
+  // Ensure WebP is enabled to run decoder tests.
+  nsresult rv = Preferences::SetBool("image.webp.enabled", true);
+  EXPECT_TRUE(rv == NS_OK);
+
   // Ensure AVIF is enabled to run decoder tests.
-  nsresult rv = Preferences::SetBool("image.avif.enabled", true);
+  rv = Preferences::SetBool("image.avif.enabled", true);
   EXPECT_TRUE(rv == NS_OK);
 
   // Ensure that ImageLib services are initialized.

image/test/mochitest/test_animation_operators.html

@@ -159,7 +159,7 @@ function runTests()
 SimpleTest.waitForExplicitFinish();
 SimpleTest.requestFlakyTimeout("untriaged");
 
-runTests();
+SpecialPowers.pushPrefEnv({"set": [["image.webp.enabled", true]]}, runTests);
 
 </script>
 </pre>

image/test/mochitest/test_discardAnimatedImage.html

@@ -37,7 +37,8 @@ var gNumDiscards = 0;
 window.onload = function() {
   // Enable discarding for the test.
   SpecialPowers.pushPrefEnv({
-    'set':[['image.mem.discardable',true]]
+    'set':[['image.mem.discardable',true],
+           ['image.webp.enabled',true]]
   }, runTest);
 }
 

modules/libpref/init/StaticPrefList.yaml

@@ -4589,6 +4589,12 @@
   value: -1
   mirror: once
 
+# Whether we attempt to decode WebP images or not.
+- name: image.webp.enabled
+  type: RelaxedAtomicBool
+  value: true
+  mirror: always
+
 # Whether we attempt to decode AVIF images or not.
 - name: image.avif.enabled
   type: RelaxedAtomicBool