Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 19:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1536659 - docshell/ automated ESLint no-throw-literal fixes. r=nika

Browse Source 
Result of running:
$ mach eslint -funix docshell/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24367

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Ian Moody 2019-03-21 16:53:45 +00:00
parent 4b64fa649d
commit b6cbc669dc
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
docshell/test/chrome/docshell_helpers.js
View File

@ -112,25 +112,25 @@ function doPageNavigation(params) {
// Do some sanity checking on arguments.
if (back && forward)
throw "Can't specify both back and forward";
throw new Error("Can't specify both back and forward");
if (back && uri)
throw "Can't specify both back and a uri";
throw new Error("Can't specify both back and a uri");
if (forward && uri)
throw "Can't specify both forward and a uri";
throw new Error("Can't specify both forward and a uri");
if (reload && (forward || back || uri))
throw "Can't specify reload and another navigation type";
throw new Error("Can't specify reload and another navigation type");
if (!back && !forward && !uri && !reload && !waitOnly)
throw "Must specify back or foward or reload or uri";
throw new Error("Must specify back or foward or reload or uri");
if (params.onNavComplete && eventsToListenFor.length == 0)
throw "Can't use onNavComplete when eventsToListenFor == []";
throw new Error("Can't use onNavComplete when eventsToListenFor == []");
if (params.preventBFCache && eventsToListenFor.length == 0)
throw "Can't use preventBFCache when eventsToListenFor == []";
throw new Error("Can't use preventBFCache when eventsToListenFor == []");
if (params.preventBFCache && waitOnly)
throw "Can't prevent bfcaching when only waiting for events";
throw new Error("Can't prevent bfcaching when only waiting for events");
if (waitOnly && typeof(params.onNavComplete) == "undefined")
throw "Must specify onNavComplete when specifying waitForEventsOnly";
throw new Error("Must specify onNavComplete when specifying waitForEventsOnly");
if (waitOnly && (back || forward || reload || uri))
throw "Can't specify a navigation type when using waitForEventsOnly";
throw new Error("Can't specify a navigation type when using waitForEventsOnly");
for (let anEventType of eventsToListenFor) {
let eventFound = false;
if ( (anEventType == "pageshow") && (!gExpectedEvents) )
@ -180,7 +180,7 @@ function doPageNavigation(params) {
} else if (waitOnly) {
gNavType = NAV_NONE;
} else {
throw "No valid navigation type passed to doPageNavigation!";
throw new Error("No valid navigation type passed to doPageNavigation!");
}
// If we're listening for events and there is an .onNavComplete callback,

2
docshell/test/navigation/NavigationUtils.js
View File

@ -163,7 +163,7 @@ function xpcWaitForFinishedFrames(callback, numFrames) {
}
if (finishedFrameCount > numFrames)
throw "Too many frames loaded.";
throw new Error("Too many frames loaded.");
}
var finishedWindows = [];