Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-12 12:55:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed leak of the BrowserWindow in WebCrawler / Added nsViewerApp::CloseWindow()

Browse Source
This commit is contained in:
pierre%netscape.com 1999-02-12 19:11:24 +00:00
parent d7c08c9ad1
commit b7382c0909
4 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webshell/tests/viewer/nsBrowserWindow.cpp
View File

@ -315,9 +315,8 @@ HandleBrowserEvent(nsGUIEvent *aEvent)
case NS_DESTROY:
{
nsViewerApp* app = bw->mApp;
app->CloseWindow(bw);
result = nsEventStatus_eConsumeDoDefault;
bw->Close();
NS_RELEASE(bw);
#ifndef XP_MAC
// XXX Really shouldn't just exit, we should just notify somebody...

10
webshell/tests/viewer/nsViewerApp.cpp
View File

@ -614,6 +614,16 @@ nsViewerApp::OpenWindow()
return NS_OK;
}
NS_IMETHODIMP
nsViewerApp::CloseWindow(nsBrowserWindow* aBrowserWindow)
{
aBrowserWindow->Close();
NS_RELEASE(aBrowserWindow);
mCrawler->SetBrowserWindow(nsnull);
return NS_OK;
}
NS_IMETHODIMP
nsViewerApp::ViewSource(nsString& aURL)
{

1
webshell/tests/viewer/nsViewerApp.h
View File

@ -52,6 +52,7 @@ public:
NS_IMETHOD Initialize(int argc, char** argv);
NS_IMETHOD ProcessArguments(int argc, char** argv);
NS_IMETHOD OpenWindow();
NS_IMETHOD CloseWindow(nsBrowserWindow* aBrowserWindow);
NS_IMETHOD ViewSource(nsString& aURL);
NS_IMETHOD OpenWindow(PRUint32 aNewChromeMask, nsIBrowserWindow*& aNewWindow);
NS_IMETHOD CreateRobot(nsBrowserWindow* aWindow);

3
webshell/tests/viewer/nsWebCrawler.cpp
View File

@ -657,8 +657,9 @@ nsWebCrawler::FindMoreURLs()
void
nsWebCrawler::SetBrowserWindow(nsIBrowserWindow* aWindow)
{
NS_IF_RELEASE(mBrowser);
mBrowser = aWindow;
NS_ADDREF(mBrowser);
NS_IF_ADDREF(mBrowser);
}
static void