Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-17 22:32:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1804745 [wpt PR 37409] - Miss the cache when breaking before a fragment with low break appeal., a=testonly

Browse Source 
Automatic update from web-platform-tests
Miss the cache when breaking before a fragment with low break appeal.

If a fragment doesn't fit in the fragmentainer, we should of course
break before it. This normally happens automatically, but in some cases
the machinery needs an extra nudge. FinishFragmentation() will in some
cases clamp the break (inside) appeal down to kBreakAppealLastResort.
We need to miss the cache if we find such layout results in the cache,
since the break appeal may no longer be valid, when we have moved over
to a new fragmentainer. Otherwise we will never let the node fit in the
previous fragmentainer, not even after making the fragmentainers taller.
This leads to correctness issues, and also freezes during column
balancing, since no fragmentainer stretch amount will be enough to pull
the node back to the first fragmentainer.

Bug: 1395408, 1399449
Change-Id: Ic0fc032b0b7022dfb9e5c35af75e09d8b3f50316
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4085506
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1081158}

--

wpt-commits: e9fc77e6ef8591b00d6934ba7ac15e3e668926f8
wpt-pr: 37409
This commit is contained in:
Morten Stenshorne 2022-12-11 21:38:01 +00:00 committed by moz-wptsync-bot
parent 6c40db2d0e
commit b7dd92bb0c
4 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
testing/web-platform/tests/css/css-break/flexbox/increase-fragmentainer-size-flex-item-trailing-margin.html Normal file
View File

@ -0,0 +1,16 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1395408">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1399449">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div id="mc" style="columns:1; width:100px; column-fill:auto; height:90px; background:red;">
<div style="height:40px; background:green;"></div>
<div style="display:flex; background:green;">
<div style="margin-bottom:10px; height:50px; width:100px;"></div>
</div>
</div>
<script>
document.body.offsetTop;
mc.style.height = "100px";
</script>

13
testing/web-platform/tests/css/css-break/increase-fragmentainer-size-tall-border.html Normal file
View File

@ -0,0 +1,13 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1395408">
<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div id="mc" style="columns:1; width:100px; column-fill:auto; height:60px; background:red;">
<div style="height:50px; background:green;"></div>
<div style="display:flow-root; border-top:50px solid green;"></div>
</div>
<script>
document.body.offsetTop;
mc.style.height = "100px";
</script>

13
testing/web-platform/tests/css/css-multicol/crashtests/balancing-flex-item-trailing-margin-freeze.html Normal file
View File

@ -0,0 +1,13 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1395408">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1399449">
<div style="columns:2;">
<div style="contain:size; height:40px;">PASS if no freeze.</div>
<div style="display:flex;">
<div style="contain:size; margin-bottom:2px; height:30px; width:100px;"></div>
</div>
<div style="display:flex;">
<div style="contain:size; margin-bottom:2px; height:30px; width:100px;"></div>
</div>
</div>

8
testing/web-platform/tests/css/css-multicol/crashtests/balancing-tall-borders-freeze.html Normal file
View File

@ -0,0 +1,8 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1395408">
<div style="columns:2;">
<div style="contain:size; height:40px;">PASS if no freeze.</div>
<div style="display:flow-root; border-top:32px solid;"></div>
<div style="display:flow-root; border-top:32px solid;"></div>
</div>