Bug 1411865 - Remove dead code from PdfJsNetwork.jsm r=bdahl

-  `onProgressiveData` callback is never set, so everything that is
   conditional on it can be removed.
- `loadedRequests` has never been used, it can be removed.
- Several other methods are unused and not part of any interface;
  These can also be removed.

Differential Revision: https://phabricator.services.mozilla.com/D24745

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Rob Wu 2019-04-01 15:56:02 +00:00
parent 484db81418
commit b802e8546e

View File

@ -55,7 +55,6 @@ var NetworkManager = (function NetworkManagerClosure() {
this.currXhrId = 0; this.currXhrId = 0;
this.pendingRequests = Object.create(null); this.pendingRequests = Object.create(null);
this.loadedRequests = Object.create(null);
} }
requestRange(begin, end, listeners) { requestRange(begin, end, listeners) {
@ -97,14 +96,7 @@ var NetworkManager = (function NetworkManagerClosure() {
pendingRequest.expectedStatus = 200; pendingRequest.expectedStatus = 200;
} }
var useMozChunkedLoading = !!args.onProgressiveData;
if (useMozChunkedLoading) {
xhr.responseType = "moz-chunked-arraybuffer";
pendingRequest.onProgressiveData = args.onProgressiveData;
pendingRequest.mozChunked = true;
} else {
xhr.responseType = "arraybuffer"; xhr.responseType = "arraybuffer";
}
if (args.onError) { if (args.onError) {
xhr.onerror = function(evt) { xhr.onerror = function(evt) {
@ -131,11 +123,6 @@ var NetworkManager = (function NetworkManagerClosure() {
return; return;
} }
if (pendingRequest.mozChunked) {
var chunk = getArrayBuffer(pendingRequest.xhr);
pendingRequest.onProgressiveData(chunk);
}
var onProgress = pendingRequest.onProgress; var onProgress = pendingRequest.onProgress;
if (onProgress) { if (onProgress) {
onProgress(evt); onProgress(evt);
@ -191,8 +178,6 @@ var NetworkManager = (function NetworkManagerClosure() {
return; return;
} }
this.loadedRequests[xhrId] = true;
var chunk = getArrayBuffer(xhr); var chunk = getArrayBuffer(xhr);
if (xhrStatus === PARTIAL_CONTENT_RESPONSE) { if (xhrStatus === PARTIAL_CONTENT_RESPONSE) {
var rangeHeader = xhr.getResponseHeader("Content-Range"); var rangeHeader = xhr.getResponseHeader("Content-Range");
@ -202,8 +187,6 @@ var NetworkManager = (function NetworkManagerClosure() {
begin, begin,
chunk, chunk,
}); });
} else if (pendingRequest.onProgressiveData) {
pendingRequest.onDone(null);
} else if (chunk) { } else if (chunk) {
pendingRequest.onDone({ pendingRequest.onDone({
begin: 0, begin: 0,
@ -221,22 +204,6 @@ var NetworkManager = (function NetworkManagerClosure() {
return false; return false;
} }
getRequestXhr(xhrId) {
return this.pendingRequests[xhrId].xhr;
}
isStreamingRequest(xhrId) {
return !!(this.pendingRequests[xhrId].onProgressiveData);
}
isPendingRequest(xhrId) {
return xhrId in this.pendingRequests;
}
isLoadedRequest(xhrId) {
return xhrId in this.loadedRequests;
}
abortAllRequests() { abortAllRequests() {
for (var xhrId in this.pendingRequests) { for (var xhrId in this.pendingRequests) {
this.abortRequest(xhrId | 0); this.abortRequest(xhrId | 0);