Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-12 12:55:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1407026 - Fix CPOW class mistake in the console. r=nchevobbe

Browse Source 
MozReview-Commit-ID: 3Mk2kclTReX

--HG--
extra : rebase_source : a52bdf1d1c56f53f6723fe5465958adb81e0cc35
This commit is contained in:
Oriol Brufau 2017-10-10 22:37:29 +02:00
parent 9fb6d528ad
commit b8394ce023
3 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
devtools/client/webconsole/new-console-output/test/mochitest/browser_console.js
View File

@ -197,4 +197,16 @@ function* testCPOWInspection(hud) {
// Just a sanity check to make sure a valid packet came back
is(prototypeAndProperties.prototype.class, "XBL prototype JSClass",
"Looks like a valid response");
// The CPOW is in the _contentWindow property.
let cpow = prototypeAndProperties.ownProperties._contentWindow.value;
// But it's only a CPOW in e10s.
let e10sCheck = yield hud.jsterm.requestEvaluation(
"Cu.isCrossProcessWrapper(gBrowser.selectedBrowser._contentWindow)");
if (e10sCheck.result) {
is(cpow.class, "CPOW: Window", "The CPOW grip has the right class.");
} else {
is(cpow.class, "Window", "The object is not a CPOW.");
}
}

12
devtools/client/webconsole/test/browser_console.js
View File

@ -197,4 +197,16 @@ function* testCPOWInspection(hud) {
// Just a sanity check to make sure a valid packet came back
is(prototypeAndProperties.prototype.class, "XBL prototype JSClass",
"Looks like a valid response");
// The CPOW is in the _contentWindow property.
let cpow = prototypeAndProperties.ownProperties._contentWindow.value;
// But it's only a CPOW in e10s.
let e10sCheck = yield hud.jsterm.requestEvaluation(
"Cu.isCrossProcessWrapper(gBrowser.selectedBrowser._contentWindow)");
if (e10sCheck.result) {
is(cpow.class, "CPOW: Window", "The CPOW grip has the right class.");
} else {
is(cpow.class, "Window", "The object is not a CPOW.");
}
}

2
devtools/server/actors/object.js
View File

@ -83,7 +83,7 @@ ObjectActor.prototype = {
let unwrapped = DevToolsUtils.unwrap(this.obj);
if (!unwrapped) {
if (DevToolsUtils.isCPOW(this.obj)) {
g.class = "CPOW: " + g.class;
g.class = "CPOW: " + this.obj.class;
} else {
g.class = "Inaccessible";
}