Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 16:55:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1636557 - [remote] Return class name and description for DOM nodes in Runtime.callFunctionOn and Runtime.evalute. r=remote-protocol-reviewers,maja_zf

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D74454
This commit is contained in:
Henrik Skupin 2020-05-09 15:06:30 +00:00
parent 870c5c304f
commit b87caead47
3 changed files with 55 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
remote/domains/content/runtime/ExecutionContext.jsm
View File

@ -414,6 +414,11 @@ class ExecutionContext {
result.subtype = "typedarray";
} else if (Node.isInstance(rawObj)) {
result.subtype = "node";
result.className = ChromeUtils.getClassName(rawObj);
result.description = rawObj.localName || rawObj.nodeName;
if (rawObj.id) {
result.description += `#${rawObj.id}`;
}
}
return result;
}

36
remote/test/browser/runtime/browser_callFunctionOn_returnByValue.js
View File

@ -3,8 +3,6 @@
"use strict";
const TEST_DOC = toDataURL("default-test-page");
add_task(async function returnAsObjectTypes({ client }) {
const { Runtime } = client;
@ -23,27 +21,43 @@ add_task(async function returnAsObjectTypes({ client }) {
{ expression: "[1, 2]", type: "object", subtype: "array" },
{ expression: "new Proxy({}, {})", type: "object", subtype: "proxy" },
{ expression: "new Date()", type: "object", subtype: "date" },
{ expression: "document", type: "object", subtype: "node" },
{ expression: "document.documentElement", type: "object", subtype: "node" },
{
expression: "document.createElement('div')",
expression: "document",
type: "object",
subtype: "node",
className: "HTMLDocument",
description: "#document",
},
{
expression: `{{
const div = document.createElement('div');
div.id = "foo";
return div;
}}`,
type: "object",
subtype: "node",
className: "HTMLDivElement",
description: "div#foo",
},
];
for (const { expression, type, subtype } of expressions) {
for (const entry of expressions) {
const { expression, type, subtype, className, description } = entry;
const { result } = await Runtime.callFunctionOn({
functionDeclaration: `() => ${expression}`,
executionContextId,
});
is(
result.subtype,
subtype,
`Evaluating '${expression}' has the expected subtype`
);
is(result.type, type, "The type is correct");
is(result.subtype, subtype, "The subtype is correct");
ok(!!result.objectId, "Got an object id");
if (className) {
is(result.className, className, "The className is correct");
}
if (description) {
is(result.description, description, "The description is correct");
}
}
});

34
remote/test/browser/runtime/browser_evaluate.js
View File

@ -205,24 +205,40 @@ add_task(async function returnAsObjectTypes({ client }) {
{ expression: "[1, 2]", type: "object", subtype: "array" },
{ expression: "new Proxy({}, {})", type: "object", subtype: "proxy" },
{ expression: "new Date()", type: "object", subtype: "date" },
{ expression: "document", type: "object", subtype: "node" },
{ expression: "document.documentElement", type: "object", subtype: "node" },
{
expression: "document.createElement('div')",
expression: "document",
type: "object",
subtype: "node",
className: "HTMLDocument",
description: "#document",
},
{
expression: `(() => {{
const div = document.createElement('div');
div.id = "foo";
return div;
}})()`,
type: "object",
subtype: "node",
className: "HTMLDivElement",
description: "div#foo",
},
];
for (const { expression, type, subtype } of expressions) {
for (const entry of expressions) {
const { expression, type, subtype, className, description } = entry;
const { result } = await Runtime.evaluate({ expression });
is(
result.subtype,
subtype,
`Evaluating '${expression}' has the expected subtype`
);
is(result.type, type, "The type is correct");
is(result.subtype, subtype, "The subtype is correct");
ok(!!result.objectId, "Got an object id");
if (className) {
is(result.className, className, "The className is correct");
}
if (description) {
is(result.description, description, "The description is correct");
}
}
});