Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 00:32:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1463373 - Throw rather than assert if buggy module resolve hook returns a module we didn't expect r=anba

Browse Source
This commit is contained in:
Jon Coppeard 2018-05-25 11:42:32 +01:00
parent 3659b3ea86
commit b95fd0ded3
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/src/builtin/Module.js
View File

@ -350,8 +350,8 @@ function InnerModuleInstantiation(module, stack, index)
}
// Step 3
assert(module.status === MODULE_STATUS_UNINSTANTIATED,
"Bad module status in ModuleDeclarationInstantiation");
if (module.status !== MODULE_STATUS_UNINSTANTIATED)
ThrowInternalError(JSMSG_BAD_MODULE_STATUS);
// Steps 4
ModuleSetStatus(module, MODULE_STATUS_INSTANTIATING);

11
js/src/jit-test/tests/modules/bug-1463373.js Normal file
View File

@ -0,0 +1,11 @@
// |jit-test| error: InternalError
let m = parseModule(`
let c = parseModule(\`
import "a";
\`);
c.declarationInstantiation();
`);
setModuleResolveHook(function(module, specifier) { return m; });
m.declarationInstantiation();
m.evaluation();