Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-12 12:55:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1224580. Copy of URLSearchParams should not copy its observer pointer. r=baku

Browse Source
This commit is contained in:
Boris Zbarsky 2015-11-16 13:29:57 -05:00
parent f4152a3bed
commit b9ac672526
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dom/base/URLSearchParams.cpp
View File

@ -315,7 +315,7 @@ URLSearchParams::URLSearchParams(nsISupports* aParent,
const URLSearchParams& aOther)
: mParams(new URLParams(*aOther.mParams.get()))
, mParent(aParent)
, mObserver(aOther.mObserver)
, mObserver(nullptr)
{
}

15
dom/base/test/test_urlSearchParams.html
View File

@ -300,6 +300,20 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=887836
runTest();
}
function testCopyConstructor() {
var url = new URL("http://example.com/");
var p = url.searchParams;
var q = new URLSearchParams(p);
q.set("a", "b");
is(url.href, "http://example.com/",
"Messing with copy of URLSearchParams should not affect URL");
p.set("c", "d");
is(url.href, "http://example.com/?c=d",
"Messing with URLSearchParams should affect URL");
runTest();
}
var tests = [
testSimpleURLSearchParams,
testCopyURLSearchParams,
@ -314,6 +328,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=887836
testSet,
testIterable,
testZeroHandling,
testCopyConstructor,
];
function runTest() {