Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 23:02:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1831263: fix(webgpu): track forgotten strong refs. in shader compilation r=webgpu-reviewers,jgilbert

Browse Source 
Co-Authored-By: Kelsey Gilbert <jgilbert@mozilla.com>

Differential Revision: https://phabricator.services.mozilla.com/D179812
This commit is contained in:
Erich Gubler 2023-06-05 16:47:54 +00:00
parent 27e4816536
commit b9b09f1036
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dom/webgpu/CompilationInfo.cpp
View File

@ -10,7 +10,7 @@
namespace mozilla::webgpu {
GPU_IMPL_CYCLE_COLLECTION(CompilationInfo, mParent)
GPU_IMPL_CYCLE_COLLECTION(CompilationInfo, mParent, mMessages)
GPU_IMPL_JS_WRAP(CompilationInfo)
CompilationInfo::CompilationInfo(ShaderModule* const aParent)

2
dom/webgpu/ShaderModule.cpp
View File

@ -13,7 +13,7 @@
namespace mozilla::webgpu {
GPU_IMPL_CYCLE_COLLECTION(ShaderModule, mParent)
GPU_IMPL_CYCLE_COLLECTION(ShaderModule, mParent, mCompilationInfo)
GPU_IMPL_JS_WRAP(ShaderModule)
ShaderModule::ShaderModule(Device* const aParent, RawId aId,

4
dom/webgpu/ShaderModule.h
View File

@ -17,9 +17,7 @@ class Device;
class ShaderModule final : public ObjectBase, public ChildOf<Device> {
public:
GPU_DECL_CYCLE_COLLECTION(
ShaderModule) // TODO: kvark's WIP patch was passing CompilationInfo as a
// second argument here.
GPU_DECL_CYCLE_COLLECTION(ShaderModule)
GPU_DECL_JS_WRAP(ShaderModule)
ShaderModule(Device* const aParent, RawId aId,