Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-13 21:35:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1116615 - Remove unneeded UI thread Runnable from GeckoMenuItem updater r=rnewman

Browse Source
This commit is contained in:
Mark Finkle 2014-12-31 01:37:54 -05:00
parent 8be6026657
commit ba19dc9232
1 changed files with 9 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
mobile/android/base/menu/GeckoMenu.java
View File

@ -517,24 +517,16 @@ public class GeckoMenu extends ListView
}
if (actionView != null) {
// The update could be coming from the background thread.
// Post a runnable on the UI thread of the view for it to update.
final GeckoMenuItem menuItem = item;
actionView.post(new Runnable() {
@Override
public void run() {
if (menuItem.isVisible()) {
actionView.setVisibility(View.VISIBLE);
if (actionView instanceof MenuItemActionBar) {
((MenuItemActionBar) actionView).initialize(menuItem);
} else {
((MenuItemActionView) actionView).initialize(menuItem);
}
} else {
actionView.setVisibility(View.GONE);
}
if (item.isVisible()) {
actionView.setVisibility(View.VISIBLE);
if (actionView instanceof MenuItemActionBar) {
((MenuItemActionBar) actionView).initialize(item);
} else {
((MenuItemActionView) actionView).initialize(item);
}
});
} else {
actionView.setVisibility(View.GONE);
}
}
} else {
mAdapter.notifyDataSetChanged();