Bug 1095926 - Fix -Wcomment warning in OCSP test and mark some OCSP tests as FAIL_ON_WARNINGS. r=briansmith

This commit is contained in:
Chris Peterson 2014-10-11 20:13:45 -07:00
parent c6ee3a8723
commit ba22404db5
5 changed files with 14 additions and 2 deletions

View File

@ -20,3 +20,5 @@ LOCAL_INCLUDES += [
include('/ipc/chromium/chromium-config.mozbuild')
FINAL_LIBRARY = 'xul-gtest'
FAIL_ON_WARNINGS = True

View File

@ -14,3 +14,5 @@ SharedLibrary('pkcs11testmodule')
# just export all the symbols.
NO_VISIBILITY_FLAGS = True
NO_DIST_INSTALL = True
FAIL_ON_WARNINGS = True

View File

@ -171,8 +171,7 @@ GetOCSPResponseForType(OCSPResponseType aORT, CERTCertificate *aCert,
}
OCSPResponseExtension extension;
if (aORT == ORTCriticalExtension || aORT == ORTNoncriticalExtension) {
// python DottedOIDToCode.py --tlv some-Mozilla-OID \
// 1.3.6.1.4.1.13769.666.666.666.1.500.9.2
// python DottedOIDToCode.py --tlv some-Mozilla-OID 1.3.6.1.4.1.13769.666.666.666.1.500.9.2
static const uint8_t tlv_some_Mozilla_OID[] = {
0x06, 0x12, 0x2b, 0x06, 0x01, 0x04, 0x01, 0xeb, 0x49, 0x85, 0x1a, 0x85,
0x1a, 0x85, 0x1a, 0x01, 0x83, 0x74, 0x09, 0x02

View File

@ -15,3 +15,5 @@ LOCAL_INCLUDES += [
]
Library('tlsserver')
FAIL_ON_WARNINGS = True

View File

@ -34,3 +34,10 @@ DISABLE_STL_WRAPPING = True
OS_LIBS += [
'dbghelp',
]
if CONFIG['_MSC_VER']:
CXXFLAGS += [
'-wd4275', # non dll-interface class exception used as base for dll-interface class
]
FAIL_ON_WARNINGS = True