Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 03:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1638458 - Remove the ignoreRootScrollFrame parameter of FrameLoader.sendCrossProcessMouseEvent(). r=tnikkel

Browse Source 
No one is setting this parameter to true any more.

Depends on D75734

Differential Revision: https://phabricator.services.mozilla.com/D75735
This commit is contained in:
Botond Ballo 2020-05-18 03:05:32 +00:00
parent 906c16b536
commit ba458447b3
9 changed files with 12 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dom/base/nsFrameLoader.cpp
View File

@ -2708,7 +2708,6 @@ void nsFrameLoader::SendCrossProcessMouseEvent(const nsAString& aType, float aX,
float aY, int32_t aButton,
int32_t aClickCount,
int32_t aModifiers,
bool aIgnoreRootScrollFrame,
ErrorResult& aRv) {
auto* browserParent = GetBrowserParent();
if (!browserParent) {
@ -2716,8 +2715,8 @@ void nsFrameLoader::SendCrossProcessMouseEvent(const nsAString& aType, float aX,
return;
}
browserParent->SendMouseEvent(aType, aX, aY, aButton, aClickCount, aModifiers,
aIgnoreRootScrollFrame);
browserParent->SendMouseEvent(aType, aX, aY, aButton, aClickCount,
aModifiers);
}
void nsFrameLoader::ActivateFrameEvent(const nsAString& aType, bool aCapture,

1
dom/base/nsFrameLoader.h
View File

@ -201,7 +201,6 @@ class nsFrameLoader final : public nsStubMutationObserver,
void SendCrossProcessMouseEvent(const nsAString& aType, float aX, float aY,
int32_t aButton, int32_t aClickCount,
int32_t aModifiers,
bool aIgnoreRootScrollFrame,
mozilla::ErrorResult& aRv);
void ActivateFrameEvent(const nsAString& aType, bool aCapture,

3
dom/chrome-webidl/FrameLoader.webidl
View File

@ -76,8 +76,7 @@ interface FrameLoader {
float aY,
long aButton,
long aClickCount,
long aModifiers,
optional boolean aIgnoreRootScrollFrame = false);
long aModifiers);
/**
* Activate event forwarding from client (remote frame) to parent.

4
dom/ipc/BrowserChild.cpp
View File

@ -1459,7 +1459,7 @@ mozilla::ipc::IPCResult BrowserChild::RecvStopIMEStateManagement() {
mozilla::ipc::IPCResult BrowserChild::RecvMouseEvent(
const nsString& aType, const float& aX, const float& aY,
const int32_t& aButton, const int32_t& aClickCount,
const int32_t& aModifiers, const bool& aIgnoreRootScrollFrame) {
const int32_t& aModifiers) {
// IPDL doesn't hold a strong reference to protocols as they're not required
// to be refcounted. This function can run script, which may trigger a nested
// event loop, which may release this, so we hold a strong reference here.
@ -1467,7 +1467,7 @@ mozilla::ipc::IPCResult BrowserChild::RecvMouseEvent(
RefPtr<PresShell> presShell = GetTopLevelPresShell();
APZCCallbackHelper::DispatchMouseEvent(
presShell, aType, CSSPoint(aX, aY), aButton, aClickCount, aModifiers,
aIgnoreRootScrollFrame, MouseEvent_Binding::MOZ_SOURCE_UNKNOWN,
false, MouseEvent_Binding::MOZ_SOURCE_UNKNOWN,
0 /* Use the default value here. */);
return IPC_OK();
}

3
dom/ipc/BrowserChild.h
View File

@ -295,8 +295,7 @@ class BrowserChild final : public nsMessageManagerScriptExecutor,
const float& aY,
const int32_t& aButton,
const int32_t& aClickCount,
const int32_t& aModifiers,
const bool& aIgnoreRootScrollFrame);
const int32_t& aModifiers);
mozilla::ipc::IPCResult RecvRealMouseMoveEvent(
const mozilla::WidgetMouseEvent& aEvent, const ScrollableLayerGuid& aGuid,

6
dom/ipc/BrowserParent.cpp
View File

@ -1356,12 +1356,10 @@ IPCResult BrowserParent::RecvNewWindowGlobal(
void BrowserParent::SendMouseEvent(const nsAString& aType, float aX, float aY,
int32_t aButton, int32_t aClickCount,
int32_t aModifiers,
bool aIgnoreRootScrollFrame) {
int32_t aModifiers) {
if (!mIsDestroyed) {
Unused << PBrowserParent::SendMouseEvent(nsString(aType), aX, aY, aButton,
aClickCount, aModifiers,
aIgnoreRootScrollFrame);
aClickCount, aModifiers);
}
}

3
dom/ipc/BrowserParent.h
View File

@ -570,8 +570,7 @@ class BrowserParent final : public PBrowserParent,
mozilla::ipc::IPCResult RecvResetPrefersReducedMotionOverrideForTest();
void SendMouseEvent(const nsAString& aType, float aX, float aY,
int32_t aButton, int32_t aClickCount, int32_t aModifiers,
bool aIgnoreRootScrollFrame);
int32_t aButton, int32_t aClickCount, int32_t aModifiers);
/**
* The following Send*Event() marks aEvent as posted to remote process if

3
dom/ipc/PBrowser.ipdl
View File

@ -747,8 +747,7 @@ child:
float aY,
int32_t aButton,
int32_t aClickCount,
int32_t aModifiers,
bool aIgnoreRootScrollFrame);
int32_t aModifiers);
/**
* When two consecutive mouse move events would be added to the message queue,

4
dom/ipc/test.xhtml
View File

@ -70,8 +70,8 @@
var frameLoader = document.getElementById('page').frameLoader;
var x = parseInt(Math.random() * 100);
var y = parseInt(Math.random() * 100);
frameLoader.sendCrossProcessMouseEvent("mousedown", x, y, 0, 1, 0, false);
frameLoader.sendCrossProcessMouseEvent("mouseup", x, y, 0, 1, 0, false);
frameLoader.sendCrossProcessMouseEvent("mousedown", x, y, 0, 1, 0);
frameLoader.sendCrossProcessMouseEvent("mouseup", x, y, 0, 1, 0);
}
function openWindow() {