Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 01:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1468343 - Part 3: Change tooltip content to address infinity duration. r=flod,jdescottes

Browse Source 
MozReview-Commit-ID: 4DXXbhGgWF1

--HG--
extra : rebase_source : 6b1d60c2145360a53eccd5c645222544186d0a11
This commit is contained in:
Daisuke Akatsuka 2018-06-26 17:21:17 +09:00
parent 8d088259fc
commit baa2f53ea1
2 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
devtools/client/inspector/animation/components/graph/SummaryGraph.js
View File

@ -57,7 +57,9 @@ class SummaryGraph extends PureComponent {
// Adding the duration.
text += getStr("player.animationDurationLabel") + " ";
text += getTime(state.duration);
text += state.duration === Infinity
? getStr("player.infiniteDurationText")
: getTime(state.duration);
text += "\n";
// Adding the endDelay.
@ -76,10 +78,11 @@ class SummaryGraph extends PureComponent {
// Adding the iteration start.
if (state.iterationStart !== 0) {
const iterationStartTime = state.iterationStart * state.duration / 1000;
text += getFormatStr("player.animationIterationStartLabel",
text += getFormatStr("player.animationIterationStartLabel2",
state.iterationStart,
numberWithDecimals(iterationStartTime, 2));
state.duration === Infinity
? getStr("player.infiniteDurationText")
: getTime(state.iterationStart * state.duration));
text += "\n";
}

16
devtools/client/locales/en-US/animationinspector.properties
View File

@ -36,6 +36,11 @@ panel.allAnimations=All animations
# displayed before the animation duration.
player.animationDurationLabel=Duration:
# LOCALIZATION NOTE (player.infiniteDurationText):
# This string is displayed in a tooltip on animation player widget, in case the
# duration of the animation is infinite.
player.infiniteDurationText=∞
# LOCALIZATION NOTE (player.animationDelayLabel):
# This string is displayed in each animation player widget. It is the label
# displayed before the animation delay.
@ -75,6 +80,17 @@ player.infiniteIterationCountText=∞
# %2$S will be replaced by the actual time of iteration start
player.animationIterationStartLabel=Iteration start: %1$S (%2$Ss)
# LOCALIZATION NOTE (player.animationIterationStartLabel2):
# This string is displayed in a tooltip that appears when hovering over
# animations in the timeline. It is the label displayed before the animation
# iterationStart value.
# %1$S will be replaced by the original iteration start value
# %2$S will be replaced by the actual time of iteration start without time unit
# e.g.
# If iterationStart of animation is 0.5 and duration is 1 sec, the string will be
# "Iteration start: 0.5 (0.5s)"
player.animationIterationStartLabel2=Iteration start: %1$S (%2$S)
# LOCALIZATION NOTE (player.animationOverallEasingLabel):
# This string is displayed in a tooltip that appears when hovering over
# animations in the timeline. It is the label displayed before the easing