Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-25 20:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 798020: Reduce severity of fatal assert about unconstrained-width flexbox, since gigantic widths in web content can reach our "unconstrained" sentinel value, and it's not actually dangerous. r=dbaron

Browse Source
This commit is contained in:
Daniel Holbert 2012-10-16 19:04:23 -07:00
parent 0e5afd7a1f
commit bb021b1e90
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
layout/generic/crashtests/798020-1.html Normal file
View File

@ -0,0 +1,4 @@
<!DOCTYPE html>
<html>
<body style="letter-spacing: 693626589697em;"><div style="display: inline-flex;">data</div></body>
</html>

1
layout/generic/crashtests/crashtests.list
View File

@ -393,3 +393,4 @@ test-pref(layout.css.flexbox.enabled,true) load 737313-2.html
test-pref(layout.css.flexbox.enabled,true) load 737313-3.html test-pref(layout.css.flexbox.enabled,true) load 737313-3.html
load 762764-1.html load 762764-1.html
load 786740-1.html load 786740-1.html
asserts(8) test-pref(layout.css.flexbox.enabled,true) load 798020-1.html

4
layout/generic/nsFlexContainerFrame.cpp
View File

@ -1790,9 +1790,9 @@ nsFlexContainerFrame::ComputeFlexContainerMainSize(
return mainSize; return mainSize;
} }
MOZ_ASSERT(!IsAxisHorizontal(aAxisTracker.GetMainAxis()), NS_WARN_IF_FALSE(!IsAxisHorizontal(aAxisTracker.GetMainAxis()),
"Computed width should always be constrained, so horizontal " "Computed width should always be constrained, so horizontal "
"flex containers should always have a constrained main-size"); "flex containers should have a constrained main-size");
// Otherwise, use the sum of our items' hypothetical main sizes, clamped // Otherwise, use the sum of our items' hypothetical main sizes, clamped
// to our computed min/max main-size properties. // to our computed min/max main-size properties.