Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 19:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1850303 - Refactor page is untranslated r=gregtatum

Browse Source 
Refactors assertions related to testing that the page
is untranslated in the Translations test suite.

Differential Revision: https://phabricator.services.mozilla.com/D186901
This commit is contained in:
Erik Nordin 2023-09-06 16:30:58 +00:00
parent 697527671e
commit bb12b0ff5a
17 changed files with 66 additions and 512 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

83
browser/components/translations/tests/browser/browser_translations_panel_always_translate_language.js
View File

@ -20,18 +20,7 @@ add_task(async function test_toggle_always_translate_language_menuitem() {
"The translations button is visible."
);
info(
'The document language "es" is not in the alwaysTranslateLanguages pref, ' +
"so the page should be untranslated, in its original form"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
info(
"Simulate clicking always-translate-language in the settings menu, " +
@ -115,18 +104,7 @@ add_task(async function test_toggle_always_translate_language_menuitem() {
"Only the button appears"
);
info(
"The page should no longer automatically translated because the document language " +
"should be removed from the always-translate pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
});
@ -149,18 +127,7 @@ add_task(
"The button is available."
);
info(
'The document language "es" is not in the alwaysTranslateLanguages pref, ' +
"so the page should be untranslated, in its original form"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",
@ -239,18 +206,7 @@ add_task(
"Only the button appears"
);
info(
"The page should no longer automatically translated because the document language " +
"should be removed from the always-translate pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
}
@ -274,18 +230,7 @@ add_task(
"The translations button is visible."
);
info(
'The document language "es" is not in the alwaysTranslateLanguages pref, ' +
"so the page should be untranslated, in its original form"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
info(
"Simulate clicking always-translate-language in the settings menu, " +
@ -376,14 +321,7 @@ add_task(
"The button is reverted to have an icon."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is restored to Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
info(
"Simulate clicking always-translate-language in the settings menu, " +
@ -407,14 +345,7 @@ add_task(
"The button shows only the icon."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is restored to Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
}

13
browser/components/translations/tests/browser/browser_translations_panel_app_menu_never_translate_language.js
View File

@ -20,18 +20,7 @@ add_task(async function test_uncheck_never_translate_language_shows_button() {
"The translations button is available"
);
info(
"The page should still be in its original, untranslated form because " +
"the document language is in the neverTranslateLanguages pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
info(
"Simulate clicking always-translate-language in the settings menu, " +

23
browser/components/translations/tests/browser/browser_translations_panel_app_menu_never_translate_site.js
View File

@ -15,18 +15,7 @@ add_task(async function test_uncheck_never_translate_site_shows_button() {
permissionsUrls: [SPANISH_PAGE_URL],
});
info(
"Translations permissions are currently allowed for this test page " +
"and the page should be untranslated, in its original form."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await assertTranslationsButton(
{ button: true, circleArrows: false, locale: false, icon: true },
@ -108,15 +97,7 @@ add_task(
await assertIsAlwaysTranslateLanguage("es", { checked: true });
await assertIsNeverTranslateSite(SPANISH_PAGE_URL, { checked: true });
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
info(
"Simulate clicking never-translate-site in the settings menu, " +

9
browser/components/translations/tests/browser/browser_translations_panel_auto_translate_error_view.js
View File

@ -108,14 +108,7 @@ add_task(
await rejectDownloads(1);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
assertPanelErrorView();
info("Waiting to find the translations panel default header.");

18
browser/components/translations/tests/browser/browser_translations_panel_basics.js
View File

@ -19,14 +19,7 @@ add_task(async function test_translations_panel_basics() {
is(button.getAttribute("data-l10n-id"), "urlbar-translations-button2");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",
@ -140,14 +133,7 @@ add_task(async function test_translations_panel_basics() {
);
});
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is restored to Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await assertTranslationsButton(
{ button: true, circleArrows: false, locale: false, icon: true },

18
browser/components/translations/tests/browser/browser_translations_panel_engine_unsupported.js
View File

@ -15,14 +15,7 @@ add_task(async function test_translations_button_hidden_when_cpu_unsupported() {
prefs: [["browser.translations.simulateUnsupportedEngine", true]],
});
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await assertTranslationsButton(
{ button: false },
@ -45,14 +38,7 @@ add_task(
prefs: [["browser.translations.simulateUnsupportedEngine", true]],
});
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
const appMenuButton = getById("PanelUI-menu-button");

117
browser/components/translations/tests/browser/browser_translations_panel_never_translate_language.js
View File

@ -20,18 +20,7 @@ add_task(async function test_toggle_never_translate_language_menuitem() {
"The translations button is visible."
);
info(
'The document language "es" is not in the neverTranslateLanguages pref, ' +
"so the page should be untranslated, in its original form."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
info(
"Simulate clicking never-translate-language in the settings menu, " +
@ -43,51 +32,18 @@ add_task(async function test_toggle_never_translate_language_menuitem() {
await clickNeverTranslateLanguage();
await assertIsNeverTranslateLanguage("es", { checked: true });
info(
"The page should still be in its original, untranslated form because " +
"the document language is in the neverTranslateLanguages pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(SPANISH_PAGE_URL, "Reload the page");
info(
"The page should still be in its original, untranslated form because " +
"the document language is in the neverTranslateLanguages pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(
SPANISH_PAGE_URL_DOT_ORG,
"Navigate to a different Spanish page"
);
info(
"The page should still be in its original, untranslated form because " +
"the document language is in the neverTranslateLanguages pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
});
@ -111,18 +67,7 @@ add_task(
"The button is available."
);
info(
'The document language "es" is not in the alwaysTranslateLanguages pref, ' +
"so the page should be untranslated, in its original form"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",
@ -172,33 +117,11 @@ add_task(
await clickNeverTranslateLanguage();
await assertIsNeverTranslateLanguage("es", { checked: true });
info(
"The page should still be in its original, untranslated form because " +
"the document language is in the neverTranslateLanguages pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(SPANISH_PAGE_URL, "Reload the page");
info(
"The page should still be in its original, untranslated form because " +
"the document language is in the neverTranslateLanguages pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
}
@ -279,33 +202,11 @@ add_task(
await assertIsAlwaysTranslateLanguage("es", { checked: false });
await assertIsNeverTranslateLanguage("es", { checked: true });
info(
"The page should still be in its original, untranslated form because " +
"the document language is in the neverTranslateLanguages pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(SPANISH_PAGE_URL, "Reload the page");
info(
"The page should still be in its original, untranslated form because " +
"the document language is in the neverTranslateLanguages pref"
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
}

138
browser/components/translations/tests/browser/browser_translations_panel_never_translate_site.js
View File

@ -21,18 +21,7 @@ add_task(async function test_toggle_never_translate_site_menuitem() {
"The translations button is visible."
);
info(
"Translations permissions are currently allowed for this test page " +
"and the page should be untranslated, in its original form."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
info(
"Simulate clicking never-translate-site in the settings menu, " +
@ -44,42 +33,14 @@ add_task(async function test_toggle_never_translate_site_menuitem() {
await clickNeverTranslateSite();
await assertIsNeverTranslateSite(SPANISH_PAGE_URL, { checked: true });
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await navigate(SPANISH_PAGE_URL, "Reload the page");
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(
SPANISH_PAGE_URL_2,
"Navigate to a Spanish page with the same content principal"
);
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(
SPANISH_PAGE_URL_DOT_ORG,
@ -92,15 +53,7 @@ add_task(async function test_toggle_never_translate_site_menuitem() {
"has not been denied translations permissions"
);
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
});
@ -125,18 +78,7 @@ add_task(
"The translations button is visible."
);
info(
"Translations permissions are currently allowed for this test page " +
"and the page should be untranslated, in its original form."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",
@ -186,42 +128,18 @@ add_task(
await clickNeverTranslateSite();
await assertIsNeverTranslateSite(SPANISH_PAGE_URL, { checked: true });
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(SPANISH_PAGE_URL, "Reload the page");
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(
SPANISH_PAGE_URL_2,
"Navigate to a Spanish page with the same content principal"
);
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(
SPANISH_PAGE_URL_DOT_ORG,
@ -234,15 +152,7 @@ add_task(
"has not been denied translations permissions"
);
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
}
@ -321,42 +231,18 @@ add_task(
await assertIsAlwaysTranslateLanguage("es", { checked: true });
await assertIsNeverTranslateSite(SPANISH_PAGE_URL, { checked: true });
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(SPANISH_PAGE_URL, "Reload the page");
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(
SPANISH_PAGE_URL_2,
"Navigate to a Spanish page with the same content principal"
);
info("The page should still be in its original, untranslated form");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await navigate(
SPANISH_PAGE_URL_DOT_ORG,

9
browser/components/translations/tests/browser/browser_translations_panel_retry.js
View File

@ -17,14 +17,7 @@ add_task(async function test_translations_panel_retry() {
"The button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",

9
browser/components/translations/tests/browser/browser_translations_panel_switch_languages.js
View File

@ -17,14 +17,7 @@ add_task(async function test_translations_panel_switch_language() {
"The button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",

27
browser/components/translations/tests/browser/browser_translations_reader_mode.js
View File

@ -17,14 +17,7 @@ add_task(async function test_translations_button_hidden_in_reader_mode() {
"The translations button is visible."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await toggleReaderMode();
@ -58,14 +51,7 @@ add_task(async function test_translations_button_hidden_in_reader_mode() {
"The translations button is visible again outside of reader mode."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
});
@ -84,14 +70,7 @@ add_task(async function test_translations_persist_in_reader_mode() {
"The translations button is visible."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent("popupshown", () => {
click(button, "Opening the popup");

19
browser/components/translations/tests/browser/browser_translations_telemetry_firstrun_auto_translate.js
View File

@ -22,14 +22,7 @@ add_task(async function test_translations_telemetry_firstrun_auto_translate() {
"The button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await openTranslationsSettingsMenuViaTranslationsButton();
await clickAlwaysTranslateLanguage();
@ -162,15 +155,7 @@ add_task(async function test_translations_telemetry_firstrun_auto_translate() {
);
await assertTranslationsButton({ button: true }, "The button is available.");
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await cleanup();
});

18
browser/components/translations/tests/browser/browser_translations_telemetry_firstrun_translation_failure.js
View File

@ -27,14 +27,7 @@ add_task(async function test_translations_telemetry_firstrun_failure() {
"The button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",
@ -74,14 +67,7 @@ add_task(async function test_translations_telemetry_firstrun_failure() {
await rejectDownloads(1);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await TestTranslationsTelemetry.assertEvent(
"OpenPanel",

18
browser/components/translations/tests/browser/browser_translations_telemetry_switch_languages.js
View File

@ -17,14 +17,7 @@ add_task(async function test_translations_telemetry_switch_from_language() {
"The button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",
@ -123,14 +116,7 @@ add_task(async function test_translations_telemetry_switch_to_language() {
"The button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await waitForTranslationsPopupEvent(
"popupshown",

36
browser/components/translations/tests/browser/browser_translations_telemetry_translation_failure.js
View File

@ -26,14 +26,7 @@ add_task(
"The button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await TestTranslationsTelemetry.assertCounter(
"RequestCount",
@ -93,14 +86,7 @@ add_task(
await rejectDownloads(1);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
assertPanelErrorView();
await TestTranslationsTelemetry.assertEvent(
@ -197,14 +183,7 @@ add_task(async function test_translations_telemetry_auto_translation_failure() {
"The translations button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await assertTranslationsButton(
{ button: true, circleArrows: true, locale: false, icon: true },
@ -213,14 +192,7 @@ add_task(async function test_translations_telemetry_auto_translation_failure() {
await rejectDownloads(1);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
assertPanelErrorView();
await TestTranslationsTelemetry.assertCounter(

9
browser/components/translations/tests/browser/browser_translations_telemetry_translation_request.js
View File

@ -17,14 +17,7 @@ add_task(async function test_translations_telemetry_manual_translation() {
"The button is available."
);
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is in Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
await assertPageIsUntranslated(runInPage);
await TestTranslationsTelemetry.assertCounter(
"RequestCount",

14
browser/components/translations/tests/browser/head.js
View File

@ -27,6 +27,20 @@ const getIntlDisplayName = (() => {
};
})();
async function assertPageIsUntranslated(runInPage, message = null) {
if (message) {
info(message);
}
await runInPage(async TranslationsTest => {
const { getH1 } = TranslationsTest.getSelectors();
await TranslationsTest.assertTranslationResult(
"The page's H1 is untranslated and in the original Spanish.",
getH1,
"Don Quijote de La Mancha"
);
});
}
/**
* Assert some property about the translations button.
*