Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-23 18:26:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1339777 - Collect telemetry for String generics. r=arai,janerik data-review=chutten

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D17257

--HG--
extra : rebase_source : 12fc69cf83bb9b92790f105367af4d03626d6295
This commit is contained in:
Tom Schuster 2019-01-22 17:54:12 +01:00
parent 30574c3d8b
commit bbf30da9de
4 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
js/src/jsfriendapi.h
View File

@ -170,6 +170,7 @@ enum {
JS_TELEMETRY_GC_MARK_RATE,
JS_TELEMETRY_PRIVILEGED_PARSER_COMPILE_LAZY_AFTER_MS,
JS_TELEMETRY_WEB_PARSER_COMPILE_LAZY_AFTER_MS,
JS_TELEMETRY_DEPRECATED_STRING_GENERICS,
JS_TELEMETRY_END
};

5
js/src/vm/SelfHosting.cpp
View File

@ -2043,6 +2043,11 @@ static bool intrinsic_WarnDeprecatedStringMethod(JSContext* cx, unsigned argc,
nameChars, nameChars)) {
return false;
}
if (!cx->realm()->isProbablySystemCode()) {
cx->runtime()->addTelemetry(JS_TELEMETRY_DEPRECATED_STRING_GENERICS, id);
}
cx->realm()->warnedAboutStringGenericsMethods |= mask;
}

3
js/xpconnect/src/XPCJSRuntime.cpp
View File

@ -2741,6 +2741,9 @@ static void AccumulateTelemetryCallback(int id, uint32_t sample,
case JS_TELEMETRY_GC_MARK_RATE:
Telemetry::Accumulate(Telemetry::GC_MARK_RATE, sample);
break;
case JS_TELEMETRY_DEPRECATED_STRING_GENERICS:
Telemetry::Accumulate(Telemetry::JS_DEPRECATED_STRING_GENERICS, sample);
break;
default:
MOZ_ASSERT_UNREACHABLE("Unexpected JS_TELEMETRY id");
}

9
toolkit/components/telemetry/Histograms.json
View File

@ -1019,6 +1019,15 @@
"n_buckets": 10,
"description": "Time elapsed between the moment a function is lazy-parsed (end of parsing of the ScriptSource) and the moment it is recompiled as non-lazy (start of compilation), in milliseconds, for web code."
},
"JS_DEPRECATED_STRING_GENERICS": {
"record_in_processes": ["content"],
"alert_emails": ["jdemooij@mozilla.com"],
"expires_in_version": "72",
"bug_numbers": [1339777],
"kind": "enumerated",
"n_values": 25,
"description": "A string generic function was called, like String.join etc. See STRING_GENERICS_* defines in SelfHostingDefines.h for the meaning of values."
},
"XUL_CACHE_DISABLED": {
"record_in_processes": ["main", "content"],
"expires_in_version": "default",