Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1218393 - Give a summary for object-count leak checking. r=jgriffin

Browse Source
This commit is contained in:
Andrew McCreight 2015-10-28 10:54:00 +01:00
parent 7b71527d7d
commit bc202dceee
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
testing/mozbase/mozleak/mozleak/leaklog.py
View File

@ -140,14 +140,15 @@ def process_single_leak_file(leakLogFileName, processType, leakThreshold,
logAsWarning = True
continue
if name != "TOTAL" and numLeaked != 0 and recordLeakedObjects:
leakedObjectNames.append(name)
currExpectedLeak = expectedLeaks.get(name, 0)
if not expectedLeaks or numLeaked <= currExpectedLeak:
if not expectedLeaks:
leakedObjectNames.append(name)
leakedObjectAnalysis.append("TEST-INFO | leakcheck | %s leaked %d %s"
% (processString, numLeaked, name))
else:
leakedObjectAnalysis.append("TEST-UNEXPECTED-FAIL | leakcheck | %s leaked too many %s (expected %d, got %d)"
leakedObjectNames.append(name)
leakedObjectAnalysis.append("WARNING | leakcheck | %s leaked too many %s (expected %d, got %d)"
% (processString, name, currExpectedLeak, numLeaked))
@ -179,8 +180,7 @@ def process_single_leak_file(leakLogFileName, processType, leakThreshold,
processString)
return
# totalBytesLeaked was seen and is non-zero.
if totalBytesLeaked > leakThreshold:
if totalBytesLeaked > leakThreshold or (expectedLeaks and leakedObjectNames):
logAsWarning = True
# Fail the run if we're over the threshold (which defaults to 0)
prefix = "TEST-UNEXPECTED-FAIL"
@ -194,6 +194,8 @@ def process_single_leak_file(leakLogFileName, processType, leakThreshold,
if len(leakedObjectNames) > maxSummaryObjects:
leakedObjectSummary += ', ...'
# totalBytesLeaked will include any expected leaks, so it can be off
# by a few thousand bytes.
if logAsWarning:
log.warning("%s | leakcheck | %s %d bytes leaked (%s)"
% (prefix, processString, totalBytesLeaked, leakedObjectSummary))