Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 05:11:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1879816: Ensure that balanced calls to nsCocoaWindow::SetModal result in balanced modal state. r=mstange

Browse Source 
It is important that calls to this function have no early exits and
process all the side effects. The side effects of this function affect
the behavior of other/future windows. So whether or not this particular
native window has already been destroyed can't affect whether or not the
app is in a modal state.

Differential Revision: https://phabricator.services.mozilla.com/D202496
This commit is contained in:
Brad Werth 2024-02-22 20:15:55 +00:00
parent 1fd31df479
commit bcea61fa68
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
widget/cocoa/nsCocoaWindow.mm
View File

@ -718,7 +718,15 @@ bool nsCocoaWindow::IsVisible() const {
void nsCocoaWindow::SetModal(bool aState) {
NS_OBJC_BEGIN_TRY_IGNORE_BLOCK;
if (!mWindow) return;
// Unlike many functions here, we explicitly *do not check* for the
// existence of mWindow. This is to ensure that calls to SetModal have
// no early exits and always update state. That way, if the calls are
// balanced, we get expected behavior even if the native window has
// been destroyed during the modal period. Within this function, all
// the calls to mWindow will resolve even if mWindow is nil (as is
// guaranteed by Objective-C). And since those calls are only concerned
// with changing mWindow appearance/level, it's fine for them to be
// no-ops if mWindow has already been destroyed.
// This is used during startup (outside the event loop) when creating
// the add-ons compatibility checking dialog and the profile manager UI;