Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 22:05:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1023451 - Part 1: introduce a hook for determining whether a locale should be included in the list. r=mcomella

Browse Source
This commit is contained in:
Richard Newman 2014-06-20 14:31:53 -07:00
parent 46e8421108
commit bcfbbf867a
1 changed files with 31 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
mobile/android/base/preferences/LocaleListPreference.java
View File

@ -7,7 +7,9 @@ package org.mozilla.gecko.preferences;
import java.text.Collator;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashSet;
import java.util.Locale;
import java.util.Set;
import org.mozilla.gecko.BrowserLocaleManager;
import org.mozilla.gecko.R;
@ -86,9 +88,23 @@ public class LocaleListPreference extends ListPreference {
// We sort by name, so we use Collator.
return COLLATOR.compare(this.nativeName, another.nativeName);
}
/**
* @return true if this locale can be used for displaying UI
* on this device without known issues.
*/
public boolean isUsable() {
return true;
}
}
private LocaleDescriptor[] getShippingLocales() {
/**
* Not every locale we ship can be used on every device, due to
* font or rendering constraints.
*
* This method filters down the list before generating the descriptor array.
*/
private LocaleDescriptor[] getUsableLocales() {
Collection<String> shippingLocales = BrowserLocaleManager.getPackagedLocaleTags(getContext());
// Future: single-locale builds should be specified, too.
@ -97,15 +113,22 @@ public class LocaleListPreference extends ListPreference {
return new LocaleDescriptor[] { new LocaleDescriptor(fallbackTag) };
}
final int count = shippingLocales.size();
final LocaleDescriptor[] descriptors = new LocaleDescriptor[count];
int i = 0;
final int initialCount = shippingLocales.size();
final Set<LocaleDescriptor> locales = new HashSet<LocaleDescriptor>(initialCount);
for (String tag : shippingLocales) {
descriptors[i++] = new LocaleDescriptor(tag);
final LocaleDescriptor descriptor = new LocaleDescriptor(tag);
if (!descriptor.isUsable()) {
Log.w(LOG_TAG, "Skipping locale " + tag + " on this device.");
continue;
}
locales.add(descriptor);
}
Arrays.sort(descriptors, 0, count);
final int usableCount = locales.size();
final LocaleDescriptor[] descriptors = locales.toArray(new LocaleDescriptor[usableCount]);
Arrays.sort(descriptors, 0, usableCount);
return descriptors;
}
@ -154,7 +177,7 @@ public class LocaleListPreference extends ListPreference {
return;
}
final LocaleDescriptor[] descriptors = getShippingLocales();
final LocaleDescriptor[] descriptors = getUsableLocales();
final int count = descriptors.length;
this.entriesLocale = currentLocale;