Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 20:35:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Patch for bug 234875: use ->param in quips.cgi; r=kiko, a=justdave.

Browse Source
This commit is contained in:
jocuri%softhome.net 2004-03-06 09:08:46 +00:00
parent 25f1709d26
commit bd3d7d1f4d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
webtools/bugzilla/quips.cgi
View File

@ -45,7 +45,7 @@ if (Param('enablequips') eq "off") {
ThrowUserError("quips_disabled");
}
my $action = $::FORM{'action'} || "";
my $action = $cgi->param('action') || "";
if ($action eq "show") {
# Read in the entire quip list
@ -81,7 +81,7 @@ if ($action eq "add") {
# Add the quip
my $approved = (Param('enablequips') eq "on") ? '1' : '0';
$approved = 1 if(UserInGroup('admin'));
my $comment = $::FORM{"quip"};
my $comment = $cgi->param("quip");
$comment || ThrowUserError("need_quip");
$comment !~ m/</ || ThrowUserError("no_html_in_quips");
@ -104,7 +104,7 @@ if ($action eq 'approve') {
my @approved;
my @unapproved;
foreach my $quipid (keys %quips) {
my $form = ($::FORM{'quipid_'.$quipid}) ? 1 : 0;
my $form = $cgi->param('quipid_'.$quipid) ? 1 : 0;
if($quips{$quipid} ne $form) {
if($form) { push(@approved, $quipid); }
else { push(@unapproved, $quipid); }
@ -122,7 +122,7 @@ if ($action eq "delete") {
if (!UserInGroup('admin')) {
ThrowUserError("quips_edit_denied");
}
my $quipid = $::FORM{"quipid"};
my $quipid = $cgi->param("quipid");
ThrowCodeError("need_quipid") unless $quipid =~ /(\d+)/;
$quipid = $1;