Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-04 15:51:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1574428: IAccessible2_2::relationTargetsOfType: Support 0 for all targets and fix off-by-one error. r=MarcoZ

Browse Source 
1. As per the spec, if maxTargets is 0, return all targets.
2. Where maxTargets > 0, fix the loop condition so it doesn't incorrectly fetch one more target than requested.

Differential Revision: https://phabricator.services.mozilla.com/D42446

--HG--
extra : moz-landing-system : lando
This commit is contained in:
James Teh 2019-08-19 05:58:49 +00:00
parent 87aa804651
commit bda9b87fdb
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
accessible/windows/ia2/ia2Accessible.cpp
View File

@ -493,8 +493,9 @@ ia2Accessible::get_relationTargetsOfType(BSTR aType, long aMaxTargets,
MOZ_ASSERT(!acc->IsProxy());
Relation rel = acc->RelationByType(*relationType);
Accessible* target = nullptr;
while ((target = rel.Next()) &&
static_cast<long>(targets.Length()) <= aMaxTargets) {
while (
(target = rel.Next()) &&
(aMaxTargets == 0 || static_cast<long>(targets.Length()) < aMaxTargets)) {
targets.AppendElement(target);
}