Bug 1635016 - Remove the rest of the SetTransactionLogging glue. r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D74866

browser/base/content/browser-graphics-utils.js

@@ -41,12 +41,4 @@ var gGfxUtils = {
   toggleWebrenderCaptureSequence() {
     window.windowUtils.wrToggleCaptureSequence();
   },
-
-  /**
-   * Toggle transaction logging to text file.
-   */
-  toggleTransactionLogging() {
-    window.windowUtils.setTransactionLogging(!this._isTransactionLogging);
-    this._isTransactionLogging = !this._isTransactionLogging;
-  },
 };

browser/base/content/browser-sets.inc

@@ -106,7 +106,6 @@
     <command id="wrToggleCaptureSequenceCmd" oncommand="gGfxUtils.toggleWebrenderCaptureSequence();" disabled="true"/>
 #ifdef NIGHTLY_BUILD
     <command id="windowRecordingCmd" oncommand="gGfxUtils.toggleWindowRecording();"/>
-    <command id="wrTransactionLoggingCmd" oncommand="gGfxUtils.toggleTransactionLogging();"/>
 #endif
 #ifdef XP_MACOSX
     <command id="minimizeWindow"
@@ -354,13 +353,6 @@
     key="$" modifiers="control"
 #endif
     command="windowRecordingCmd"/>
-    <key id="key_transactionLoggingCmd"
-#ifdef XP_MACOSX
-    key="5" modifiers="control,shift"
-#else
-    key="%" modifiers="control"
-#endif
-    command="wrTransactionLoggingCmd"/>
 #endif
 #ifdef XP_MACOSX
     <key id="key_minimizeWindow"

dom/base/nsDOMWindowUtils.cpp

@@ -4242,14 +4242,6 @@ nsDOMWindowUtils::StopCompositionRecording(bool aWriteToDisk,
   return NS_OK;
 }
 
-NS_IMETHODIMP
-nsDOMWindowUtils::SetTransactionLogging(bool aValue) {
-  if (WebRenderBridgeChild* wrbc = GetWebRenderBridge()) {
-    wrbc->SetTransactionLogging(aValue);
-  }
-  return NS_OK;
-}
-
 NS_IMETHODIMP
 nsDOMWindowUtils::SetSystemFont(const nsACString& aFontName) {
   nsIWidget* widget = GetWidget();

dom/interfaces/base/nsIDOMWindowUtils.idl

@@ -1975,11 +1975,6 @@ interface nsIDOMWindowUtils : nsISupports {
    */
   Promise stopCompositionRecording(in boolean aWriteToDisk);
 
-  /**
-   * Toggle transaction logging on and off.
-   */
-  void setTransactionLogging(in boolean aValue);
-
   /**
    * Returns whether the document we're associated to has recorded a given CSS
    * property via the use counter mechanism.

gfx/layers/ipc/PWebRenderBridge.ipdl

@@ -75,9 +75,6 @@ parent:
   // Start capturing each frame and save to disk, and if already started, stop.
   async ToggleCaptureSequence();
 
-  // Enable/Disable transaction logging
-  async SetTransactionLogging(bool aValue);
-
   // Replacement for PCompositorBridge::SyncWithCompositor, but for WR. We need
   // it on PWebRenderBridge because it associated with a particular top-level
   // window, and PCompositorBridge doesn't allow doing that in a secure manner.

gfx/layers/wr/WebRenderBridgeChild.cpp

@@ -603,9 +603,5 @@ void WebRenderBridgeChild::ToggleCaptureSequence() {
   this->SendToggleCaptureSequence();
 }
 
-void WebRenderBridgeChild::SetTransactionLogging(bool aValue) {
-  this->SendSetTransactionLogging(aValue);
-}
-
 }  // namespace layers
 }  // namespace mozilla

gfx/layers/wr/WebRenderBridgeChild.h

@@ -175,7 +175,6 @@ class WebRenderBridgeChild final : public PWebRenderBridgeChild,
 
   void Capture();
   void ToggleCaptureSequence();
-  void SetTransactionLogging(bool aValue);
 
  private:
   friend class CompositorBridgeChild;

gfx/layers/wr/WebRenderBridgeParent.cpp

@@ -1842,14 +1842,6 @@ mozilla::ipc::IPCResult WebRenderBridgeParent::RecvToggleCaptureSequence() {
   return IPC_OK();
 }
 
-mozilla::ipc::IPCResult WebRenderBridgeParent::RecvSetTransactionLogging(
-    const bool& aValue) {
-  if (!mDestroyed) {
-    mApi->SetTransactionLogging(aValue);
-  }
-  return IPC_OK();
-}
-
 mozilla::ipc::IPCResult WebRenderBridgeParent::RecvSyncWithCompositor() {
   FlushSceneBuilds();
   if (RefPtr<WebRenderBridgeParent> root = GetRootWebRenderBridgeParent()) {

gfx/layers/wr/WebRenderBridgeParent.h

@@ -173,7 +173,6 @@ class WebRenderBridgeParent final
   mozilla::ipc::IPCResult RecvScheduleComposite() override;
   mozilla::ipc::IPCResult RecvCapture() override;
   mozilla::ipc::IPCResult RecvToggleCaptureSequence() override;
-  mozilla::ipc::IPCResult RecvSetTransactionLogging(const bool&) override;
   mozilla::ipc::IPCResult RecvSyncWithCompositor() override;
 
   mozilla::ipc::IPCResult RecvSetConfirmedTargetAPZC(

gfx/webrender_bindings/WebRenderAPI.cpp

@@ -614,10 +614,6 @@ void WebRenderAPI::ToggleCaptureSequence() {
   }
 }
 
-void WebRenderAPI::SetTransactionLogging(bool aValue) {
-  wr_api_set_transaction_logging(mDocHandle, aValue);
-}
-
 void WebRenderAPI::SetCompositionRecorder(
     UniquePtr<layers::WebRenderCompositionRecorder> aRecorder) {
   class SetCompositionRecorderEvent final : public RendererEvent {

gfx/webrender_bindings/WebRenderAPI.h

@@ -273,8 +273,6 @@ class WebRenderAPI final {
 
   void ToggleCaptureSequence();
 
-  void SetTransactionLogging(bool aValue);
-
   void SetCompositionRecorder(
       UniquePtr<layers::WebRenderCompositionRecorder> aRecorder);
 

gfx/webrender_bindings/src/bindings.rs

@@ -2075,11 +2075,6 @@ pub extern "C" fn wr_api_stop_capture_sequence(dh: &mut DocumentHandle) {
     dh.api.stop_capture_sequence();
 }
 
-#[no_mangle]
-pub extern "C" fn wr_api_set_transaction_logging(dh: &mut DocumentHandle, aValue: bool) {
-    dh.api.send_debug_cmd(DebugCommand::SetTransactionLogging(aValue));
-}
-
 #[cfg(target_os = "windows")]
 fn read_font_descriptor(bytes: &mut WrVecU8, index: u32) -> NativeFontHandle {
     let wchars = bytes.convert_into_vec::<u16>();

gfx/wr/webrender/src/renderer.rs

@@ -3120,7 +3120,6 @@ impl Renderer {
     fn handle_debug_command(&mut self, command: DebugCommand) {
         match command {
             DebugCommand::EnableDualSourceBlending(_) |
-            DebugCommand::SetTransactionLogging(_) |
             DebugCommand::SetPictureTileSize(_) => {
                 panic!("Should be handled by render backend");
             }

gfx/wr/webrender_api/src/api.rs

@@ -965,8 +965,6 @@ pub enum DebugCommand {
     /// Causes the low priority scene builder to pause for a given amount of milliseconds
     /// each time it processes a transaction.
     SimulateLongLowPrioritySceneBuild(u32),
-    /// Logs transactions to a file for debugging purposes
-    SetTransactionLogging(bool),
     /// Set an override tile size to use for picture caches
     SetPictureTileSize(Option<DeviceIntSize>),
 }