Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 22:05:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1434994 - Use ReleaseAcquire for the cached serialization atomic. r=emilio

Browse Source 
MozReview-Commit-ID: 3gtoLRf8TNl
This commit is contained in:
Bobby Holley 2018-02-02 10:49:56 -08:00
parent f30d722e69
commit bdb53f7d13
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dom/base/nsAttrValueInlines.h
View File

@ -26,11 +26,14 @@ struct MiscContainer final
// Note eStringBase and eAtomBase is used also to handle the type of
// mStringBits.
//
// Note that we use a relaxed atomic here so that we can use Compare-And-Swap
// Note that we use an atomic here so that we can use Compare-And-Swap
// to cache the serialization during the parallel servo traversal. This case
// (which happens when the main thread is blocked) is the only case where
// mStringBits is mutated off-main-thread.
mozilla::Atomic<uintptr_t, mozilla::Relaxed> mStringBits;
// mStringBits is mutated off-main-thread. The Atomic needs to be
// ReleaseAcquire so that the pointer to the serialization does not become
// observable to other threads before the initialization of the pointed-to
// memory is also observable.
mozilla::Atomic<uintptr_t, mozilla::ReleaseAcquire> mStringBits;
union {
struct {
union {