Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-31 22:25:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 928450 - IonMonkey: Check for empty ranges after intersecting integer and floating-point ranges. r=nbp

Browse Source
This commit is contained in:
Dan Gohman 2013-10-21 13:04:20 -07:00
parent c1783a6a1a
commit bdba82f569
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
js/src/jit-test/tests/asm.js/bug928450.js Normal file
View File

@ -0,0 +1,6 @@
(function() {
"use asm"
function f() {
i((1.5 != 2.) ? 3 : 0)
}
})()

11
js/src/jit/RangeAnalysis.cpp
View File

@ -389,9 +389,18 @@ Range::intersect(const Range *lhs, const Range *rhs, bool *emptyRange)
// of 1.5, it may have a range like [0,2] and the max_exponent may be zero.
// When intersecting such a range with an integer range, the fractional part
// of the range is dropped, but the max exponent of 0 remains valid.
if (lhs->canHaveFractionalPart_ != rhs->canHaveFractionalPart_)
if (lhs->canHaveFractionalPart_ != rhs->canHaveFractionalPart_) {
refineInt32BoundsByExponent(newExponent, &newLower, &newUpper);
// If we're intersecting two ranges that don't overlap, this could also
// push the bounds past each other, since the actual intersection is
// the empty set.
if (newLower > newUpper) {
*emptyRange = true;
return nullptr;
}
}
return new Range(newLower, newHasInt32LowerBound, newUpper, newHasInt32UpperBound,
newFractional, newExponent);
}