mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-25 11:15:34 +00:00
Bug 1585808 - Add UTM parameters to the "Learn more about this breach" link in breach notifications. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D48597 --HG-- extra : moz-landing-system : lando
This commit is contained in:
parent
0b3c8bde66
commit
bdec1200f3
@ -116,6 +116,8 @@ this.LoginBreaches = {
|
||||
}
|
||||
|
||||
let breachAlertURL = new URL(breach.Name, baseBreachAlertURL);
|
||||
breachAlertURL.searchParams.set("utm_campaign", "Desktop");
|
||||
breachAlertURL.searchParams.set("utm_medium", "InProduct");
|
||||
breach.breachAlertURL = breachAlertURL.href;
|
||||
breachesByLoginGUID.set(login.guid, breach);
|
||||
}
|
||||
|
@ -121,7 +121,6 @@ add_task(async function test_notBreachedLogin() {
|
||||
|
||||
add_task(async function test_breachedLogin() {
|
||||
Services.logins.addLogin(BREACHED_LOGIN);
|
||||
|
||||
const breachesByLoginGUID = await LoginBreaches.getPotentialBreachesByLoginGUID(
|
||||
[NOT_BREACHED_LOGIN, BREACHED_LOGIN],
|
||||
TEST_BREACHES
|
||||
@ -131,6 +130,11 @@ add_task(async function test_breachedLogin() {
|
||||
1,
|
||||
"Should be 1 breached login: " + BREACHED_LOGIN.origin
|
||||
);
|
||||
Assert.strictEqual(
|
||||
breachesByLoginGUID.get(BREACHED_LOGIN.guid).breachAlertURL,
|
||||
"https://monitor.firefox.com/breach-details/Breached?utm_campaign=Desktop&utm_medium=InProduct",
|
||||
"Breach alert link should be equal to the breachAlertURL"
|
||||
);
|
||||
});
|
||||
|
||||
add_task(async function test_notBreachedSubdomain() {
|
||||
|
Loading…
Reference in New Issue
Block a user