Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 01:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1623971 - P3: Return false when SetMusicMetadata fails r=alwu

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D77879
This commit is contained in:
Chun-Min Chang 2020-06-19 00:20:03 +00:00
parent 9edb1ef9be
commit be44e3f059
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
widget/windows/WindowsSMTCProvider.cpp
View File

@ -359,21 +359,29 @@ bool WindowsSMTCProvider::SetMusicMetadata(const wchar_t* aArtist,
Unused << hr;
hr = mDisplay->get_MusicProperties(musicProps.GetAddressOf());
if (FAILED(hr)) {
LOG("SystemMediaTransportControls: Failed at get_MusicProperties()");
LOG("Failed to get music properties");
return false;
}
hr = musicProps->put_Artist(aArtist ? HStringReference(aArtist).Get()
: nullptr);
MOZ_ASSERT(SUCCEEDED(hr));
Unused << hr;
if (FAILED(hr)) {
LOG("Failed to set the music's artist");
return false;
}
musicProps->put_Title(HStringReference(aTitle).Get());
hr = musicProps->put_Title(HStringReference(aTitle).Get());
if (FAILED(hr)) {
LOG("Failed to set the music's title");
return false;
}
hr = musicProps->put_AlbumArtist(
aAlbumArtist ? HStringReference(aAlbumArtist).Get() : nullptr);
MOZ_ASSERT(SUCCEEDED(hr));
Unused << hr;
if (FAILED(hr)) {
LOG("Failed to set the music's album");
return false;
}
return true;
}