mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-21 01:05:45 +00:00
Bug 1623971 - P3: Return false when SetMusicMetadata
fails r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D77879
This commit is contained in:
parent
9edb1ef9be
commit
be44e3f059
@ -359,21 +359,29 @@ bool WindowsSMTCProvider::SetMusicMetadata(const wchar_t* aArtist,
|
|||||||
Unused << hr;
|
Unused << hr;
|
||||||
hr = mDisplay->get_MusicProperties(musicProps.GetAddressOf());
|
hr = mDisplay->get_MusicProperties(musicProps.GetAddressOf());
|
||||||
if (FAILED(hr)) {
|
if (FAILED(hr)) {
|
||||||
LOG("SystemMediaTransportControls: Failed at get_MusicProperties()");
|
LOG("Failed to get music properties");
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
hr = musicProps->put_Artist(aArtist ? HStringReference(aArtist).Get()
|
hr = musicProps->put_Artist(aArtist ? HStringReference(aArtist).Get()
|
||||||
: nullptr);
|
: nullptr);
|
||||||
MOZ_ASSERT(SUCCEEDED(hr));
|
if (FAILED(hr)) {
|
||||||
Unused << hr;
|
LOG("Failed to set the music's artist");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
musicProps->put_Title(HStringReference(aTitle).Get());
|
hr = musicProps->put_Title(HStringReference(aTitle).Get());
|
||||||
|
if (FAILED(hr)) {
|
||||||
|
LOG("Failed to set the music's title");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
hr = musicProps->put_AlbumArtist(
|
hr = musicProps->put_AlbumArtist(
|
||||||
aAlbumArtist ? HStringReference(aAlbumArtist).Get() : nullptr);
|
aAlbumArtist ? HStringReference(aAlbumArtist).Get() : nullptr);
|
||||||
MOZ_ASSERT(SUCCEEDED(hr));
|
if (FAILED(hr)) {
|
||||||
Unused << hr;
|
LOG("Failed to set the music's album");
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user