Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 20:05:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 877671 - crash in nsEventListenerManager::RemoveEventListener, r=jst

Browse Source 
--HG--
extra : rebase_source : ee7f4547e0b9b26e8dc577d7a530491c2004876c
This commit is contained in:
Olli Pettay 2013-05-31 14:05:23 +03:00
parent d0eb61c94b
commit bf7b3a32f1
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
layout/xul/base/src/nsXULTooltipListener.cpp
View File

@ -656,6 +656,10 @@ nsXULTooltipListener::DestroyTooltip()
nsCOMPtr<nsIDOMEventListener> kungFuDeathGrip(this);
nsCOMPtr<nsIContent> currentTooltip = do_QueryReferent(mCurrentTooltip);
if (currentTooltip) {
// release tooltip before removing listener to prevent our destructor from
// being called recursively (bug 120863)
mCurrentTooltip = nullptr;
// clear out the tooltip node on the document
nsCOMPtr<nsIDocument> doc = currentTooltip->GetDocument();
if (doc) {
@ -668,12 +672,8 @@ nsXULTooltipListener::DestroyTooltip()
doc->RemoveSystemEventListener(NS_LITERAL_STRING("keydown"), this, true);
}
// release tooltip before removing listener to prevent our destructor from
// being called recursively (bug 120863)
mCurrentTooltip = nullptr;
// remove the popuphidden listener from tooltip
currentTooltip->RemoveEventListener(NS_LITERAL_STRING("popuphiding"), this, false);
currentTooltip->RemoveSystemEventListener(NS_LITERAL_STRING("popuphiding"), this, false);
}
// kill any ongoing timers